1283006 - [Remote Control] Fennec cannot pairing with TV after TV's network disconnect and connect again

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Mike Lien[:mlien]]

[Testing Steps]
0. Fennec and TV connect to the same domain
1. Send a tab from Fennec to TV (will show first time pairing page)
2. Close pairing page
3. Disable TV's network
4. Enable TV's network
5. Repeat step 1 again

[Expected result]
Be able to show pairing page normally

[Actual result]
Cannot show pairing page normally, it will open pairing page but always under loading status

[Build Info]
Environment: 2.6 Nexus Player
gaia:
https://github.com/mozilla-b2g/gaia/commit/508825d1599d6596292e15789181568d00dd4acf
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/49b98aa3b415380cc7a021d740b242894654245a

Fennec add-on:
https://github.com/ChunMinChang/fennec-fxos-tv/commit/48bee4df266fe08e19c81e1d8aa3d4fa8b3da6c2

[Error Log]
https://gist.github.com/anonymous/95c42dc26a2dfa39dce4a97bab232b69

Comment 1

[C.M.Chang[:chunmin]]

Hi,
Does it *only* happen in the first pairing after re-enabling TV's network, or they can't build the connection permanently?

Comment 2

[Mike Lien[:mlien]]

It cannot build the connection permanently no matter first pairing or already paired before. And this situation only happen when re-enable connection from TV side. Re-enable connection from Fennec side won't have this problem.

Comment 3

[Eric Tsai (no more review request accepted)]

No sure if network stops also trigger presentation discovery stop? If so, network restarts may cause remote control restarts in different port, the port should be update.

Comment 4

[C.M.Chang[:chunmin]]

The port in Fennec side update dynamically. Would you provide some log for this problem?

Comment 5

[Mike Lien[:mlien]]

In this case, Fennec won't update remote control port while TV re-enable network.

Comment 6

[C.M.Chang[:chunmin]]

Did this happen only before you re-click the "search devices" button? Or it happen after you re-click the "search devices" button?

Comment 7

[C.M.Chang[:chunmin]]

After the TV shutdowns, MDNS should fire a "remove" event to notify add-on that the device is removed. Did you receive this event?

Comment 8

[C.M.Chang[:chunmin]]

NOTE:
1. Check whether Fennec receives the *new* port info from MDNS boardcast
2. Chech whether Fennec can receive the *remove* event from MDNS

I will check these issues today

Comment 9

[C.M.Chang[:chunmin]]

(In reply to Chun-Min Chang[:chunmin] from comment #8)
> NOTE:
> 1. Check whether Fennec receives the *new* port info from MDNS boardcast
No. The port info boardcasted by TV is not changed.
> 2. Chech whether Fennec can receive the *remove* event from MDNS
No. Fennec can't get the notification.

*Before* the TV turn-off wifi, Fennec can build the TLS connection successfully, and the openssl shows CONNECTED

> $ openssl s_client -connect 10.247.36.119:53906
> CONNECTED(00000003)
> 55786:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:/BuildRoot/Library/Caches/com.apple.xbs/Sources/OpenSSL098/OpenSSL098-59.40.2/src/ssl/s23_clnt.c:618:

*After* the TV turn-off wifi, and then turn-on wifi again, Fennec can *NOT* build the TLS connection. The openssl shows that

> $ openssl s_client -connect 10.247.36.119:53906
> connect: Operation timed out
> connect:errno=60

The above openssl might not be correct, but it gives some info at least.

Comment 10

[C.M.Chang[:chunmin]]

Note:
Check whether |dom.presentation.discoverable| is changed into |false| when wifi is turned-off.

Comment 11

[Eric Tsai (no more review request accepted)]

Attachment: Patch 1. Implement network status change observer

Root cause of this bug is when wifi turned off, tls server socket is forced to stop listening. Turn on wifi will not restart tls server socket. Solution is to add network status observer, while no active network, stop remote control service and start when active network back.

Comment 12

[C.M.Chang[:chunmin]]

Would you have time to fix the nits? Or just land it ASAP for QA's testing. I am OK for both.

Comment 13

[Eric Tsai (no more review request accepted)]

I'm fine with the nit, just fixed. You can send approve now.

Comment 14

[C.M.Chang[:chunmin]]

Comment on attachment 8766661 [details] [review]
Patch 1. Implement network status change observer

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 15

[Josh Cheng [:josh]]

Comment on attachment 8766661 [details] [review]
Patch 1. Implement network status change observer

Approve for TV 2.6

Comment 16

[Gary Chen [:xeonchen]]

https://github.com/mozilla-b2g/gecko-b2g/commit/d1df806764f9a060a02b6ec7a8af94e912580a39