1283010 - Windows nativeMessagingHost registry key/value differ from doc/Chrome

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[gorf4673]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

Steps to reproduce:

64 bit host, 32 bit Firefox
For webextension using port = chrome.runtime.connectNative('com.MyApp');

Created nativeHost registry 
SOFTWARE\Wow6432Node\Mozilla\NativeMessagingHosts\com.MyApp
(default) = "c:\myapp\com.MyApp.json"



Actual results:

On port.postMessage('echo')
recieve onDisconnect callback response

No such native application com.MyApp
this.NativeApp</this.startupPromise<()
NativeMessaging.jsm:207


Expected results:

Native application (manifest) should have been found

Comment 1

[gorf4673]

Attachment: nativeMessagingRegistry.jpg

I was looking back at the initial doc and comparing with how the registry reading is being done.
Initial SOFTWARE\Mozilla\NativeMessagingHosts\<name>
was state similar to Chrome doc   SOFTWARE\Google\Chrome\NativeMessagingHosts\<name>

In Chrome this meant having a <name> key and (@ default value) being set to the manifest.json
After some attempts and debugging, in Firefox this has changed to mean having the NativeMessagingHosts key and  <name> value being set to the manifest.json

Comment 2

[Andrew Swan [:aswan]]

Attachment: Bug 1283010 Fix windows registry paths for native messaging

Review commit: https://reviewboard.mozilla.org/r/61478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61478/

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8766664 [details]
Bug 1283010 Fix windows registry paths for native messaging

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61478/diff/1-2/

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8766664 [details]
Bug 1283010 Fix windows registry paths for native messaging

https://reviewboard.mozilla.org/r/61478/#review58696

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a8acb16142d
Fix windows registry paths for native messaging r=kmag

Comment 6

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/bba958f7cb1668e943aeae29b1ce105c6b856a2b for Windows xpcshell failures, https://treeherder.mozilla.org/logviewer.html#?job_id=333438&repo=autoland

Comment 7

[Andrew Swan [:aswan]]

Comment on attachment 8766664 [details]
Bug 1283010 Fix windows registry paths for native messaging

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61478/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f8355531f47
Fix windows registry paths for native messaging r=kmag

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4f8355531f47