Closed
Bug 1283061
Opened 9 years ago
Closed 9 years ago
HTMLInputElement type=file webkitdirectory/directory should show just 1 button
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
|
12.67 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8766262 -
Flags: review?(bugs)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8766262 [details] [diff] [review]
ui.patch
> # LOCALIZATION NOTE (NoFilesSelected): this string is shown on a
> # <input type='file' multiple> when there is no file selected yet.
> NoFilesSelected=No files selected.
>+# LOCALIZATION NOTE (NoDirSelected): this string is shown on a
>+# <input type='file' directory/webkitdirectory> when there is no directory
>+# selected yet.
>+NoDirSelected=No directory selected.
The text is a bit longer than "No files selected". Does it still look ok? Does it force the element to be much wider?
I guess it is fine, since "No files selected" doesn't take all the space.
Chrome has rather bad UI. It has just "Choose file" for webkitdirectory
Attachment #8766262 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f38b04754b1d
HTMLInputElement type=file webkitdirectory/directory should show just 1 button, r=smaug
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•