1283083 - Cloning a connection should also re-attach databases to the clone

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Marco Bonardo [:mak]]

When cloning a connection, if it has attached databases, we lose those.
That may be error prone if the consumer expects the 2 connections to work similarly (that is what we try to do by copying pragmas and functions on clone).

I think we should attach the databases to the clone.
We can use PRAGMA database_list for that.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1283083 - Cloning a connection should re-attach databases to the clone.

Review commit: https://reviewboard.mozilla.org/r/61402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61402/

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8766565 [details]
Bug 1283083 - Cloning a connection should re-attach databases to the clone.

https://reviewboard.mozilla.org/r/61402/#review58406

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/9b5be9da64ba
Cloning a connection should re-attach databases to the clone. r=asuth

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b5be9da64ba