Closed Bug 1283083 Opened 3 years ago Closed 3 years ago

Cloning a connection should also re-attach databases to the clone

Categories

(Toolkit :: Storage, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

When cloning a connection, if it has attached databases, we lose those.
That may be error prone if the consumer expects the 2 connections to work similarly (that is what we try to do by copying pragmas and functions on clone).

I think we should attach the databases to the clone.
We can use PRAGMA database_list for that.
Comment on attachment 8766565 [details]
Bug 1283083 - Cloning a connection should re-attach databases to the clone.

https://reviewboard.mozilla.org/r/61402/#review58406
Attachment #8766565 - Flags: review?(bugmail) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/fx-team/rev/9b5be9da64ba
Cloning a connection should re-attach databases to the clone. r=asuth
https://hg.mozilla.org/mozilla-central/rev/9b5be9da64ba
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.