1283186 - Only print error instead of throwing when a key shortcut is wrong

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P1)

Description

[Alexandre Poirot [:ochameau]]

We keep seeing devtools being completely broken due to wrong translation.
We may ease key shortcut module behavior by only logging to the console instead of throwing.

Comment 1

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eed43e75e6e3

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8766424 [details] [diff] [review]
patch v1

Review of attachment 8766424 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me, thanks.  Can you confirm that the frontend loads now if you set something like inspector.searchHTML.key to an invalid value?

Comment 4

[Brian Grinstead [:bgrins]]

and/or add a regression test for this in browser_key_shortcuts.js

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: patch v2

I tested that it was working with invalid default properties,
but here is an additional test.

Comment 6

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=acfd7aea4043

Comment 7

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/94d072b1e22be1b41dae68a6f91e9a2e5d232f98
Bug 1283186 - Only print error instead of throwing when a key shortcut is invalid. r=bgrins

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/94d072b1e22b