1283202 - Pulse jobs from taskcluster concatenate the retry id to the job_guid erroneously

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect)

Description

[Cameron Dawson [:camd]]

it's already in the taskId from task cluster, we don't need to append it in treeherder

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:pulse-job-guid-retryid-fix > mozilla:master

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8766560 [details] [review]
[treeherder] mozilla:pulse-job-guid-retryid-fix > mozilla:master

Got an r+ on irc from garndt

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f3eef9903de87bd97370f47542dd49736b26483d
Bug 1283202 - Stop concatenating retryId to the end of the taskId for… (#1634)

* Bug 1283202 - Stop concatenating retryId to the end of the taskId for job_guid from pulse

Comment 4

[Ed Morley [:emorley]]

Should we disallow slashes in job guids? They break URLs in the UI at the moment due to lack of URL encoding -- it seems like we should just avoid the footgun if possible?

Comment 5

[Ed Morley [:emorley]]

(ie replace '/0' with say '_0' or '-0')

Comment 6

[Cameron Dawson [:camd]]

using '_0' would cause problems because of the stupid hack I had to do for buildbot retries.  But perhaps the '-0' would work.

Greg: would that be do-able on your end?  Or if you didn't include the retry, I could do the concatenation on my end.

Comment 7

[Greg Arndt [:garndt]]

So a "-" is a valid character in a uuid which might confuse things.  Also, with any change to this format it will need to be changed in a few spots:

1. taskcluster-treeherder pulse job submission
2. mozilla-taskcluster api job submission
3. mozilla-taskcluster retrigger handling

Comment 8

[Cameron Dawson [:camd]]

Maybe the safest thing is to properly url encode our url params when using a job_guid in Treeherder.

Comment 9

[Cameron Dawson [:camd]]

since this bug is resolved, I opened bug 1283545 for this specific URL issue with job_detail