1283359 - Use StreamingLexer in the JPEG decoder

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

The JPEG decoder is the last remaining image decoder that doesn't use StreamingLexer. See bug 1282566 comment 0 for why it's important that all image decoders use StreamingLexer.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Use StreamingLexer in the JPEG decoder.

Here's the patch. The approach is the same as in bug 1282566 - just wrap the
existing decoder code in an unbuffered read. Unfortunately the existing JPEG
decoder code is somewhat hairy, so the results aren't as nice, but cleaning up
the JPEG decoder is something that we can put off for another bug.

The only thing that really had to be updated in the existing JPEG decoder state
machine was to replace simple |return| statements with |return
Transition::TerminateSuccess()| or |return Transition::TerminateFailure()|. We
continue setting the |mState| variable to indicate e.g. JPEG_ERROR for now, even
though it's not really necessary, because there is some code continuing to look
at the value in nsJPEGDecoder::FinishInternal(). We can almost certainly remove
that code, but I'd prefer to do that in a separate bug.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Try job here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c9c3d5d6c8d

Comment 3

[Seth Fowler [:seth] [:s2h]]

Thanks for the review!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23ecfc796432
Use StreamingLexer in the JPEG decoder. r=edwin

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/23ecfc796432