Closed
Bug 1283364
Opened 8 years ago
Closed 8 years ago
~TrackBuffersManager doesn't need to be virtual
Categories
(Core :: Audio/Video: Playback, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(2 files)
TrackBuffersManager's destructor is virtual, but nothing else about that class indicates it is needed: - It doesn't inherit from anything, - Nothing inherits from it (adding 'final' worked), - No other members are virtual. So I think we could lose that 'virtual'.
Assignee | ||
Comment 1•8 years ago
|
||
TBM used to inherit from now-obsolete SourceBufferContentManager, which would explain why it had a virtual destructor. It should probably have been removed as part of bug 1259274 -- Obviously the reviewer didn't do their job!
Depends on: 1259274
Assignee | ||
Comment 2•8 years ago
|
||
Follow-up to bug 1259274, where TBM lost its inheritance. Review commit: https://reviewboard.mozilla.org/r/61692/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/61692/
Attachment #8766981 -
Flags: review?(jyavenard)
Attachment #8766982 -
Flags: review?(jyavenard)
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/61694/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/61694/
Assignee | ||
Comment 4•8 years ago
|
||
Pushed review to :jya. (No hurry Jean-Yves, it can wait until you're back from PTO) Try with added 'final', just to prove that there was no hidden inheritance somewhere in the tree: https://treeherder.mozilla.org/#/jobs?repo=try&revision=23a2ad9503a31c36db241f33a151bfa0b5b24322 I don't think 'final' is really necessary here, so I'm not keeping it.
Assignee: nobody → gsquelart
Comment 5•8 years ago
|
||
Comment on attachment 8766981 [details] Bug 1283364 - Make ~TrackBuffersManager non-virtual - https://reviewboard.mozilla.org/r/61692/#review58542
Attachment #8766981 -
Flags: review?(jyavenard) → review+
Updated•8 years ago
|
Attachment #8766982 -
Flags: review?(jyavenard) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8766982 [details] Bug 1283364 - Fix brace style - https://reviewboard.mozilla.org/r/61694/#review58546
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a53ff0ca36b9 Make ~TrackBuffersManager non-virtual - r=jya https://hg.mozilla.org/integration/autoland/rev/cd5a30817ea4 Fix brace style - r=jya
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a53ff0ca36b9 https://hg.mozilla.org/mozilla-central/rev/cd5a30817ea4
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•