1283364 - ~TrackBuffersManager doesn't need to be virtual

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

TrackBuffersManager's destructor is virtual, but nothing else about that class indicates it is needed:
- It doesn't inherit from anything,
- Nothing inherits from it (adding 'final' worked),
- No other members are virtual.
So I think we could lose that 'virtual'.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

TBM used to inherit from now-obsolete SourceBufferContentManager, which would explain why it had a virtual destructor.
It should probably have been removed as part of bug 1259274 -- Obviously the reviewer didn't do their job!

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1283364 - Make ~TrackBuffersManager non-virtual -

Follow-up to bug 1259274, where TBM lost its inheritance.

Review commit: https://reviewboard.mozilla.org/r/61692/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61692/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1283364 - Fix brace style -

Review commit: https://reviewboard.mozilla.org/r/61694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61694/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Pushed review to :jya. (No hurry Jean-Yves, it can wait until you're back from PTO)

Try with added 'final', just to prove that there was no hidden inheritance somewhere in the tree:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=23a2ad9503a31c36db241f33a151bfa0b5b24322
I don't think 'final' is really necessary here, so I'm not keeping it.

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8766981 [details]
Bug 1283364 - Make ~TrackBuffersManager non-virtual -

https://reviewboard.mozilla.org/r/61692/#review58542

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8766982 [details]
Bug 1283364 - Fix brace style -

https://reviewboard.mozilla.org/r/61694/#review58546

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a53ff0ca36b9
Make ~TrackBuffersManager non-virtual - r=jya
https://hg.mozilla.org/integration/autoland/rev/cd5a30817ea4
Fix brace style - r=jya

Comment 8

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/a53ff0ca36b9
https://hg.mozilla.org/mozilla-central/rev/cd5a30817ea4