1283388 - Implement UI for <input type="datetime-local">

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, enhancement, P3)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

In order to do this, we need to tweak this condition so that you create the widget, then you need to change this code to handle datetime-local in the picker, by maybe combining the two or what not.

If someone is interested on taking this I'm happy to mentor and help with debugging and so on.

Comment 3

[Fernando García Gómez, stripTM]

Attachment: Bug 1283388 - Implementation for datetime-local input type as clone of date. r=emilio

Comment 4

[Fernando García Gómez, stripTM]

Attachment: Bug 1283388 - implementation for datetime-local input type as merge of date and time. r=emilio

Depends on D100521

Comment 5

[Fernando García Gómez, stripTM]

My proposal now would be to refactor toolkit/content/widgets/datetimebox.js
removing the classes DateInputImplWidget and TimeInputImplWidget and add logic to render date/time/datetime-local in DateTimeLocalInputImplWidget

Comment 6

[Fernando García Gómez, stripTM]

Attachment: Bug 1283388 - combine DateInputImplWidget, TimeInputImplWidget and DateTimeLocalInputImplWidget in one component DateTimeInputImplWidget. r=emilio

Depends on D100522

Comment 7

[Fernando García Gómez, stripTM]

Attachment: WIP: Bug 1283388 - Support to change input type

Depends on D105959

Comment 8

[Fernando García Gómez, stripTM]

Attachment: Bug 1283388 - Simplify setup function r=emilio

Depends on D110979

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Hi fer, sorry for the lag getting to this. This looks great, though some things:

• The picker looks broken at least on Linux.
• Your changes seem to cause toolkit/content/tests/browser/browser_datetime_datepicker.js to fail one of the tests. You can run this with ./mach mochitest toolkit/content/tests/browser/browser_datetime_datepicker.js.

This looks on the good track anyways. I've opened bug 1705946 to start landing your changes, and I'll try to look into the test failure and land the datetimebox.js refactoring next (though if you can dig into the test failure that'd be great as well of course).

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1283388 - Implement datetime-local UI. r=Gijs

Needs tests. This only shows the date picker for now (matches Safari).

Seems fine since we don't enable the time picker by default.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8aef29efdec2
Implement datetime-local UI. r=Gijs

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f71100cb98a
Backed out changeset 8aef29efdec2 for causing failures in test_MozEditableElement_setUserInput.html. CLOSED TREE

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e763489ab1e
Implement datetime-local UI. r=Gijs

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb39252d466b
Remove a bit from a reftest which doesn't apply to date/time/datetime-local inputs.

Comment 16

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6e763489ab1e
https://hg.mozilla.org/mozilla-central/rev/cb39252d466b

Comment 17

[TWC (Alt Email)]

Can this bug be reopened?

The current implementation as tested from Nightly (93.0a1) only permits picking a date, leaving the time as "--:--:--" and

This is not compliant with the specification:

• https://www.w3.org/wiki/Html/Elements/input/datetime-local
• https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local

A partial implementation confuses attempts to polyfill a functioning datetime picker.

Comment 18

[Emilio Cobos Álvarez (:emilio)]

(In reply to TWC (Alt Email) from comment #17)

The current implementation as tested from Nightly (93.0a1) only permits picking a date, leaving the time as "--:--:--"

That matches Safari (and we don't ship a time picker for <input type=time> so it is consistent with that too).

This is not compliant with the specification:

• https://www.w3.org/wiki/Html/Elements/input/datetime-local
• https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local

Why? Neither of those links is a specification. The specification is this and it doesn't specify how the UI should look like, afaict.

Can this bug be reopened?

I filed bug 1726108 for this. Reopening this fixed bug would make tracking a mess.