1283400 - [TV][2.6][FTE] Remove 'Home intro' and 'Pin to home' from TV FTE

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P2)

Description

[Mike Lien[:mlien]]

v2.5 remove TV FTE and keep it on master, do we still need it on v2.6?

+++ This bug was initially created as a clone of Bug #1240415 +++
Following 3 parts will be removed from TV FTE:

• Home intro. 
• Info frame intro. (Not implemented)
• Pin to home

Discussed with partner on-site and decide to remove them because we need to consider l10n issues.

Please remove 'Home intro' and 'Pin to home' from TV FTE

Comment 1

[Evelyn Hung]

Fischer, could you check if any patch is missing in v2.6? Thanks.

Comment 2

[Fischer [:Fischer]]

@Josh,
In the bug 1240415, The 2 FTE pages (Home intro and Pin to home) has been removed in v2.5.
Also need to remove these 2 FTE pages in v2.6 ?
Thanks

Comment 3

[Josh Cheng [:josh]]

(In reply to [:Fischer]Fischer from comment #2)
> @Josh,
> In the bug 1240415, The 2 FTE pages (Home intro and Pin to home) has been
> removed in v2.5.
> Also need to remove these 2 FTE pages in v2.6 ?
> Thanks

Yes, Please

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1283400-remove-home-fte > mozilla-b2g:v2.6

Comment 5

[Fischer [:Fischer]]

Comment on attachment 8767836 [details] [review]
[gaia] Fischer-L:bug_1283400-remove-home-fte > mozilla-b2g:v2.6

@Rex,
Like the bug 1240415, this patch removes "Home intro" and "Pin to home" FTE parts.
Thanks.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8767836 [details] [review]
[gaia] Fischer-L:bug_1283400-remove-home-fte > mozilla-b2g:v2.6

r+ for patch uplifting

Comment 7

[Fischer [:Fischer]]

Comment on attachment 8767836 [details] [review]
[gaia] Fischer-L:bug_1283400-remove-home-fte > mozilla-b2g:v2.6

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):1283400
[User impact] if declined: User would see unnecessary FTE parts
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: None

Comment 8

[Josh Cheng [:josh]]

Comment on attachment 8767836 [details] [review]
[gaia] Fischer-L:bug_1283400-remove-home-fte > mozilla-b2g:v2.6

Approve for TV 2.6

Comment 9

[Fischer [:Fischer]]

Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/85cb39d8c8770827779cb5a7a345b7eef3cdae73