1283415 - Empty poster attribute on video element throw an error

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Olivier C.]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160629030209

Steps to reproduce:

Add an empty poster attribute on a video element
see : http://jsbin.com/tetovicoxe/edit?html,console,output


Actual results:

Firefox throw an error while other vendors ignore this attribute


Expected results:

The poster attribute should be ignored 
https://www.w3.org/TR/html5/embedded-content-0.html#attr-video-poster

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1283415 - Only set the poster src on the anonymous content if the attribute is not empty.

Review commit: https://reviewboard.mozilla.org/r/62872/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62872/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8134578e0724

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8768851 [details]
Bug 1283415 - Only set the poster src on the anonymous content if the attribute is not empty.

https://reviewboard.mozilla.org/r/62872/#review59838

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Thanks Jared.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e097b3f7f21b
Only set the poster src on the anonymous content if the attribute is not empty. r=cpearce

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for reftest bustage in https://hg.mozilla.org/integration/autoland/rev/c22afe017b53

https://treeherder.mozilla.org/logviewer.html#?job_id=431736&repo=autoland

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b006200160d

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Updated patch

mozreview won't let me push this and I think it's because this already was already landed once through mozreview. "abort: reviewboard error: One or more fields had errors (HTTP 400, API Error 105); identifier: Parent review request is submitted or discarded"

I changed this patch to unset the "src" attribute on the poster image. Previously it was unsetting the "poster" attribute on the poster image, which would be non-existant anyways. This just happened to work for the reftest case that was used, since the poster attribute was still present but was set to the empty value.

Since this now follows a different codepath, it made the already present bug visible in the reftest.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60e03643f8e2
Only set the poster src on the anonymous content if the attribute is not empty. r=cpearce

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/60e03643f8e2