"ASSERTION: Clock should go forwards" changing playbackRate

RESOLVED FIXED in Firefox 50

Status

()

P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jruderman, Assigned: fatseng)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla50
assertion, testcase
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Created attachment 8766776 [details]
testcase
(Reporter)

Comment 1

3 years ago
Created attachment 8766777 [details]
stack
Farmer, 
This bug should be suitable to you. 
Please have a look.
Thanks!
Flags: needinfo?(fatseng)
(Assignee)

Comment 3

3 years ago
I will check it.
Flags: needinfo?(fatseng)
(Assignee)

Updated

3 years ago
Assignee: nobody → fatseng
Priority: -- → P2
Mass change P2 -> P3
Priority: P2 → P3
(Assignee)

Comment 5

3 years ago
http://searchfox.org/mozilla-central/source/dom/media/mediasink/AudioSinkWrapper.cpp#125
mParams.mPlaybackRate should be updated after call GetVideoPosition().
(Assignee)

Comment 6

3 years ago
I will prepare patch later.
(Assignee)

Comment 7

3 years ago
Created attachment 8769527 [details] [diff] [review]
mParams.mPlaybackRate should be updated after store mPlayDuration

Here is try server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=796bd18fa38e
Attachment #8769527 - Flags: review?(jwwang)
Comment on attachment 8769527 [details] [diff] [review]
mParams.mPlaybackRate should be updated after store mPlayDuration

Review of attachment 8769527 [details] [diff] [review]:
-----------------------------------------------------------------

I can't see how that will make a difference. Can you elaborate it?
(Assignee)

Comment 9

3 years ago
http://searchfox.org/mozilla-central/source/dom/media/mediasink/AudioSinkWrapper.cpp#133
GetVideoPosition(now) generate timestamp and store in mPlayDuration;

http://searchfox.org/mozilla-central/source/dom/media/mediasink/AudioSinkWrapper.cpp#67
but GetVideoPosition() use mParams.mPlaybackRate to calculate it.
Therefore, we should use old playback rate to generate it.
Flags: needinfo?(jwwang)
Comment on attachment 8769527 [details] [diff] [review]
mParams.mPlaybackRate should be updated after store mPlayDuration

Review of attachment 8769527 [details] [diff] [review]:
-----------------------------------------------------------------

Please add comments why mParams.mPlaybackRate should be updated after the call to GetVideoPosition().
Attachment #8769527 - Flags: review?(jwwang) → review+
Flags: needinfo?(jwwang)
(Assignee)

Comment 11

3 years ago
Created attachment 8769556 [details] [diff] [review]
0001-Bug-1283489-mParams.mPlaybackRate-should-be-updated-.patch

Carry on Comment 10
Attachment #8769527 - Attachment is obsolete: true
Attachment #8769556 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 12

3 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed9cd1e7f95a
mParams.mPlaybackRate should be updated after call GetVideoPosition(). r=jwwang
Keywords: checkin-needed

Comment 13

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ed9cd1e7f95a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.