Closed Bug 1283489 Opened 4 years ago Closed 4 years ago

"ASSERTION: Clock should go forwards" changing playbackRate

Categories

(Core :: Audio/Video: Playback, defect, P3)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: jruderman, Assigned: fatseng)

Details

(Keywords: assertion, testcase)

Attachments

(3 files, 1 obsolete file)

testcase
5.75 KB, text/html
Details
stack
4.00 KB, text/plain
Details
0001-Bug-1283489-mParams.mPlaybackRate-should-be-updated-.patch
1.21 KB, patch
fatseng
: review+
Details | Diff | Splinter Review
Attached file testcase — 
No description provided.
Attached file stack — 
Farmer, 
This bug should be suitable to you. 
Please have a look.
Thanks!
Flags: needinfo?(fatseng)
I will check it.
Flags: needinfo?(fatseng)
Assignee: nobody → fatseng
Mass change P2 -> P3
Priority: P2 → P3
http://searchfox.org/mozilla-central/source/dom/media/mediasink/AudioSinkWrapper.cpp#125
mParams.mPlaybackRate should be updated after call GetVideoPosition().
I will prepare patch later.
Comment on attachment 8769527 [details] [diff] [review]
mParams.mPlaybackRate should be updated after store mPlayDuration

Review of attachment 8769527 [details] [diff] [review]:
-----------------------------------------------------------------

I can't see how that will make a difference. Can you elaborate it?
http://searchfox.org/mozilla-central/source/dom/media/mediasink/AudioSinkWrapper.cpp#133
GetVideoPosition(now) generate timestamp and store in mPlayDuration;

http://searchfox.org/mozilla-central/source/dom/media/mediasink/AudioSinkWrapper.cpp#67
but GetVideoPosition() use mParams.mPlaybackRate to calculate it.
Therefore, we should use old playback rate to generate it.
Flags: needinfo?(jwwang)
Comment on attachment 8769527 [details] [diff] [review]
mParams.mPlaybackRate should be updated after store mPlayDuration

Review of attachment 8769527 [details] [diff] [review]:
-----------------------------------------------------------------

Please add comments why mParams.mPlaybackRate should be updated after the call to GetVideoPosition().
Attachment #8769527 - Flags: review?(jwwang) → review+
Flags: needinfo?(jwwang)
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed9cd1e7f95a
mParams.mPlaybackRate should be updated after call GetVideoPosition(). r=jwwang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ed9cd1e7f95a
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.