1283497 - "ASSERTION: These should always be in sync!" with mutation observer, designMode

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: These should always be in sync!: 'slowNode == node', file dom/base/nsINode.cpp, line 281

This assertion was first added in bug 730587 (https://hg.mozilla.org/mozilla-central/rev/5280e98d2d77) but has moved several times since then.

I'm also CCing the developers who fixed bug 1056841, which sounds like it hit the assertion with XUL.

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Ok, I think we need to expand nsElementDeletionObserver a bit to deal with unbinding too and unbind native anonymous content too.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: safer_editor_unbind_with_rebind.diff

Not sure who would be a good reviewer for this. Given that native anonymous content (nac) has somewhat similar issues as shadow DOM, perhaps wchen you could take a look.

The basic idea is that we keep the editor created NAC around with the non-NAC element unless DeleteRefToAnonymousNode (which is normally used) is called.
If the non-nac is moved to another document, we just unbind since the editor in that other document might create similar NACs.

The change to nsElementDeletionObserver::NodeWillBeDestroyed is just to make it safer, and changes to nsHTMLEditor::DeleteRefToAnonymousNode just remove some useless calls to presshell, which end up firing warnings.

Reading also nsHTMLEditor::CreateAnonymousElement may ease reviewing.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=98e3d8c7b16ceac0b2d46c732fe4bf21d78e9b93

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

review ping

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: up-to-date

There has been some renames in editor/

Comment 6

[William Chen [:wchen]]

Comment on attachment 8769646 [details] [diff] [review]
up-to-date

Review of attachment 8769646 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6ab1c8708cf
unbind editor created native anonymous content properly, r=wchen

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b6ab1c8708cf