1283542 - Automigration from Chrome is broken

Status: RESOLVED FIXED

(Firefox :: Migration, defect, P2)

Description

[:Gijs (he/him)]

The code and tests expect to deal with profile IDs, but the MigrationUtils code expects profile objects. That's fine for browsers with no profile support, but not for Chrome.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1283542 - fix profile detection code in AutoMigrate to deal with profile objects instead of identifiers,

Review commit: https://reviewboard.mozilla.org/r/61566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61566/

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 8766836 [details]
Bug 1283542 - fix profile detection code in AutoMigrate to deal with profile objects instead of identifiers,

https://reviewboard.mozilla.org/r/61566/#review58436

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4af575a99ef2
fix profile detection code in AutoMigrate to deal with profile objects instead of identifiers, r=Dolske

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/4af575a99ef2

Comment 5

[:Gijs (he/him)]

Comment on attachment 8766836 [details]
Bug 1283542 - fix profile detection code in AutoMigrate to deal with profile objects instead of identifiers,

Approval Request Comment
[Feature/regressing bug #]: automigration, used in funnelcake builds 88 (bug 1295873)
[User impact if declined]: no funnelcake. :-(
[Describe test coverage new/current, TreeHerder]: this patch updates the existing xpcshell test to match the code changes.
[Risks and why]: no risk to the main release. All of these changes are specific to automigration (so manual profile data migration from chrome was never broken by the previous change). For the funnelcake, without this change automatic migration from chrome doesn't work. The change is small - 2 lines of actual code changed, and then some comments + the test were updated, so it's still pretty low risk even for that.
[String/UUID change made/needed]: no.

Comment 6

[:Gijs (he/him)]

Comment on attachment 8766836 [details]
Bug 1283542 - fix profile detection code in AutoMigrate to deal with profile objects instead of identifiers,

Gah, so many approval flags. Beta, not aurora - this is already on 50.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8766836 [details]
Bug 1283542 - fix profile detection code in AutoMigrate to deal with profile objects instead of identifiers,

Fix for automigration from Chrome, for onboarding funnelcake in 49.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b7e08435c478