Automigration from Chrome is broken

RESOLVED FIXED in Firefox 49

Status

()

defect
P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

50 Branch
Firefox 50
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox49 fixed, firefox50 fixed, firefox51 fixed)

Details

(Whiteboard: [migration-needs-uplift])

Attachments

(1 attachment)

Assignee

Description

3 years ago
The code and tests expect to deal with profile IDs, but the MigrationUtils code expects profile objects. That's fine for browsers with no profile support, but not for Chrome.
Comment on attachment 8766836 [details]
Bug 1283542 - fix profile detection code in AutoMigrate to deal with profile objects instead of identifiers,

https://reviewboard.mozilla.org/r/61566/#review58436
Attachment #8766836 - Flags: review?(dolske) → review+

Comment 3

3 years ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4af575a99ef2
fix profile detection code in AutoMigrate to deal with profile objects instead of identifiers, r=Dolske

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4af575a99ef2
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Assignee

Updated

3 years ago
Whiteboard: [migration-needs-uplift]
Assignee

Comment 5

3 years ago
Comment on attachment 8766836 [details]
Bug 1283542 - fix profile detection code in AutoMigrate to deal with profile objects instead of identifiers,

Approval Request Comment
[Feature/regressing bug #]: automigration, used in funnelcake builds 88 (bug 1295873)
[User impact if declined]: no funnelcake. :-(
[Describe test coverage new/current, TreeHerder]: this patch updates the existing xpcshell test to match the code changes.
[Risks and why]: no risk to the main release. All of these changes are specific to automigration (so manual profile data migration from chrome was never broken by the previous change). For the funnelcake, without this change automatic migration from chrome doesn't work. The change is small - 2 lines of actual code changed, and then some comments + the test were updated, so it's still pretty low risk even for that.
[String/UUID change made/needed]: no.
Attachment #8766836 - Flags: approval-mozilla-aurora?
Assignee

Comment 6

3 years ago
Comment on attachment 8766836 [details]
Bug 1283542 - fix profile detection code in AutoMigrate to deal with profile objects instead of identifiers,

Gah, so many approval flags. Beta, not aurora - this is already on 50.
Attachment #8766836 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Comment on attachment 8766836 [details]
Bug 1283542 - fix profile detection code in AutoMigrate to deal with profile objects instead of identifiers,

Fix for automigration from Chrome, for onboarding funnelcake in 49.
Attachment #8766836 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.