1283565 - Add telemetry to record when the automigrate "undo" functionality is used

Status: RESOLVED FIXED

(Firefox :: Migration, defect, P2)

Description

[Justin Dolske [:Dolske]]

We'd like to understand how often the automigrate "undo" functionality is invoked by users. This is a clear user signal that we didn't automagically do the right thing, and will be a useful signal to look at as we fine-tune how we decide what browser to import from.

Comment 1

[:Gijs (out for now; he/him)]

Attachment: Bug 1283565 - add telemetry to determine whether undo works and how often it's unavailable due to sync

Review commit: https://reviewboard.mozilla.org/r/61586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61586/

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 8766866 [details]
Bug 1283565 - add telemetry to determine whether undo works and how often it's unavailable due to sync

https://reviewboard.mozilla.org/r/61586/#review58452

Comment 3

[Benjamin Smedberg]

Comment on attachment 8766866 [details]
Bug 1283565 - add telemetry to determine whether undo works and how often it's unavailable due to sync

https://reviewboard.mozilla.org/r/61586/#review58472

data-review=me with some better description.

::: toolkit/components/telemetry/Histograms.json:4334
(Diff revision 1)
> +    "alert_emails": ["[e-mail]"],
> +    "expires_in_version": "53",
> +    "kind": "enumerated",
> +    "n_values": 31,
> +    "releaseChannelCollection": "opt-out",
> +    "description": "Where undo of the automatic migration was attempted, indicates to what degree we succeeded to undo."

It would be really nice to document what the 31 enumerated values actually mean.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/adfe23aae513
add telemetry to determine whether undo works and how often it's unavailable due to sync, r=dolske,data-r=bsmedberg

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/adfe23aae513

Comment 6

[:Gijs (out for now; he/him)]

Comment on attachment 8766866 [details]
Bug 1283565 - add telemetry to determine whether undo works and how often it's unavailable due to sync

Approval Request Comment
[Feature/regressing bug #]: automigration, used in funnelcake builds 88 (bug 1295873)
[User impact if declined]: no data about the efficacy of the 'undo' functionality of the data migration in the funnelcake
[Describe test coverage new/current, TreeHerder]: nope, telemetry only.
[Risks and why]: low risk. All the code here is behind the pref (so won't run on general release). This is basic data gathering of how well the undo functionality works. This way we'll know pretty quickly if there are major issues with it and how it plays out with sync. Based on the QE verification of the earlier funnelcake based on 48, I'm confident that this change doesn't affect the workings of the funnelcake otherwise (and as said, it won't run at all on general release).
[String/UUID change made/needed]: no.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8766866 [details]
Bug 1283565 - add telemetry to determine whether undo works and how often it's unavailable due to sync

More telemetry that should only happen on release for funnelcake users.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ffc2be7a4b14