1283619 - Send Conduit ignores remote Remb support

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Nils Ohlmeier [:drno]]

When bug 1155435 landed it updated the REMB support in webrtc.org for receiving video condouits here:
https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/media-conduit/VideoConduit.cpp#1051

But for the sending side it is still hard coded that the receiver does not support REMB no matter what we have been agreed on in the SDP for both sides:
https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/media-conduit/VideoConduit.cpp#797

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1283619: enable far end REMB support for sending conduits depending on signaling.

Review commit: https://reviewboard.mozilla.org/r/61652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61652/

Comment 2

[Michael Froman [:mjf]]

Comment on attachment 8766940 [details]
Bug 1283619: enable far end REMB support for sending conduits depending on signaling.

https://reviewboard.mozilla.org/r/61652/#review58498

Looks good to me.

Comment 3

[Nils Ohlmeier [:drno]]

Randell: any objections to start paying attention to the remotes REMB capabilities when FF is the sender?

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

yes, definitely

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

as in - definitely land this patch

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3361195d371f
enable far end REMB support for sending conduits depending on signaling. r=mjf

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/3361195d371f

Comment 8

[Maire Reavy [:mreavy]]

Nils -- can you ask for uplift to Fx49 since REMB is enabled there?

Comment 9

[Nils Ohlmeier [:drno]]

Comment on attachment 8766940 [details]
Bug 1283619: enable far end REMB support for sending conduits depending on signaling.

Approval Request Comment
[Feature/regressing bug #]: REMB support which landed in bug 1155435 was not complete.
[User impact if declined]: REMB support will not get properly negotiated between two WebRTC parties.
[Describe test coverage new/current, TreeHerder]: Is to some degree covered by the unit tests from the original bug 1155435.
[Risks and why]: Pretty low as REMB now gets set depending on the signaling, which is what should be done.
[String/UUID change made/needed]: N/A

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8766940 [details]
Bug 1283619: enable far end REMB support for sending conduits depending on signaling.

This patch enables the support for REMB when sending conduits. Take it in aurora.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2edcaa7c3912