Closed Bug 1283619 Opened 3 years ago Closed 3 years ago

Send Conduit ignores remote Remb support

Categories

(Core :: WebRTC: Signaling, defect, P2)

49 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: drno, Assigned: drno)

References

Details

Attachments

(1 file)

When bug 1155435 landed it updated the REMB support in webrtc.org for receiving video condouits here:
https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/media-conduit/VideoConduit.cpp#1051

But for the sending side it is still hard coded that the receiver does not support REMB no matter what we have been agreed on in the SDP for both sides:
https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/src/media-conduit/VideoConduit.cpp#797
Attachment #8766940 - Flags: review?(mfroman) → review+
Comment on attachment 8766940 [details]
Bug 1283619: enable far end REMB support for sending conduits depending on signaling.

https://reviewboard.mozilla.org/r/61652/#review58498

Looks good to me.
Randell: any objections to start paying attention to the remotes REMB capabilities when FF is the sender?
Flags: needinfo?(rjesup)
yes, definitely
Flags: needinfo?(rjesup)
as in - definitely land this patch
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/3361195d371f
enable far end REMB support for sending conduits depending on signaling. r=mjf
https://hg.mozilla.org/mozilla-central/rev/3361195d371f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Nils -- can you ask for uplift to Fx49 since REMB is enabled there?
Flags: needinfo?(drno)
Comment on attachment 8766940 [details]
Bug 1283619: enable far end REMB support for sending conduits depending on signaling.

Approval Request Comment
[Feature/regressing bug #]: REMB support which landed in bug 1155435 was not complete.
[User impact if declined]: REMB support will not get properly negotiated between two WebRTC parties.
[Describe test coverage new/current, TreeHerder]: Is to some degree covered by the unit tests from the original bug 1155435.
[Risks and why]: Pretty low as REMB now gets set depending on the signaling, which is what should be done.
[String/UUID change made/needed]: N/A
Flags: needinfo?(drno)
Attachment #8766940 - Flags: approval-mozilla-aurora?
Comment on attachment 8766940 [details]
Bug 1283619: enable far end REMB support for sending conduits depending on signaling.

This patch enables the support for REMB when sending conduits. Take it in aurora.
Attachment #8766940 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.