[EME] Remove obsolete MediaKeySystemOptions config

RESOLVED FIXED in Firefox 50

Status

()

P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 1 bug)

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
We used to implement an older version of navigator.requestMediaKeySystemAccess(), which accepted a MediaKeySystemOptions struct. The current spec supports different attributes, which we've supported for a while. So it's about time we removed the obsolete attributes.
(Assignee)

Comment 1

2 years ago
Created attachment 8766976 [details]
Bug 1283666 - Remove obsolete MediaKeySystemConfiguration attributes.

They're no longer in the spec, and we and Chrome have supported the up to date
versions for a while.

Review commit: https://reviewboard.mozilla.org/r/61682/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61682/
Attachment #8766976 - Flags: review?(bugs)
Attachment #8766977 - Flags: review?(jwwang)
(Assignee)

Comment 2

2 years ago
Created attachment 8766977 [details]
Bug 1283666 - Remove code to handle obsolete MediaKeySystemConfiguration attributes.

Review commit: https://reviewboard.mozilla.org/r/61684/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61684/

Comment 3

2 years ago
Comment on attachment 8766976 [details]
Bug 1283666 - Remove obsolete MediaKeySystemConfiguration attributes.

https://reviewboard.mozilla.org/r/61682/#review58508

Looks like Chrome doesn't have these properties.
Attachment #8766976 - Flags: review?(bugs) → review+
Comment on attachment 8766977 [details]
Bug 1283666 - Remove code to handle obsolete MediaKeySystemConfiguration attributes.

https://reviewboard.mozilla.org/r/61684/#review58536
Attachment #8766977 - Flags: review?(jwwang) → review+
(Assignee)

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e32d001ffbe6bc88bf8539f1ff258c526fd9326
Bug 1283666 - Remove obsolete MediaKeySystemConfiguration attributes. r=smaug

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5adfcfffa5be0d5246f9d11ed08bdae6bd8cbd4
Bug 1283666 - Remove code to handle obsolete MediaKeySystemConfiguration attributes. r=jwwang

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1e32d001ffbe
https://hg.mozilla.org/mozilla-central/rev/f5adfcfffa5b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.