Closed
Bug 1283679
Opened 8 years ago
Closed 8 years ago
mask-composite: subtract is supported as misspelled 'substract' value
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: dbaron, Assigned: bmo)
References
Details
Attachments
(1 file)
http://searchfox.org/mozilla-central/search?q=substract&path= shows that our implementation of mask-composite supports a value that is spelled incorrectly (substract rather than subtract), and we have tests that match the misspelling.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/62002/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/62002/
Assignee | ||
Comment 2•8 years ago
|
||
upload first patch for review.
Assignee: nobody → aschen
Status: NEW → ASSIGNED
Assignee | ||
Updated•8 years ago
|
Attachment #8767548 -
Flags: review?(dbaron)
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8767548 [details] Bug 1283679 - fix misspelled mask-composite:subtract keyword. https://reviewboard.mozilla.org/r/62002/#review58848
Attachment #8767548 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 4•8 years ago
|
||
try result looks good. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2f27ca3a1a6 [2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f82d0e62581
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/03ea4596d842 fix misspelled mask-composite:subtract keyword. r=dbaron
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/03ea4596d842
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•