If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Don't disable "Expand All" context menu, if current node has a child node collapsed

VERIFIED FIXED in Firefox 50

Status

()

Firefox
Developer Tools: Inspector
P1
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: magicp, Assigned: moby)

Tracking

Trunk
Firefox 50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 unaffected, firefox50 verified)

Details

(Whiteboard: [devtools-html])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

a year ago
Created attachment 8767039 [details]
Don't disable Expand All context menu if current node has a child node collapsed.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160630030207

Steps to reproduce:

1. Start Nightly
2. Go to any sites (e.g.  about:home)
3. Open DevTools > Inspector
4. Select any nodes (e.g. <body>) and right clicking
5. Confirm "Expand All" is enabled or disabled


Actual results:

"Expand All" context menu is disabled, even if current node has a child node collapsed.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=9545df18ca9eaa35915df14e23543c02363ff83e&tochange=618a8336136754762b1002f9838fa574ffc60937


Expected results:

"Expand All" context menu should be enabled.
(Reporter)

Updated

a year ago
Blocks: 1266478
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox49: --- → unaffected
status-firefox50: --- → affected
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All
Blocks: 1259121
Whiteboard: [devtools-html] [triage]
Flags: qe-verify+
Priority: -- → P1
QA Contact: alexandra.lucinet
Whiteboard: [devtools-html] [triage] → [devtools-html]
(Assignee)

Updated

a year ago
Assignee: nobody → mvonbriesen
(Assignee)

Comment 1

a year ago
Created attachment 8769342 [details] [diff] [review]
inspector-menu-fix.patch
Attachment #8769342 - Flags: review?(bgrinstead)
Comment on attachment 8769342 [details] [diff] [review]
inspector-menu-fix.patch

Review of attachment 8769342 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, please also update this test: https://dxr.mozilla.org/mozilla-central/source/devtools/client/inspector/test/browser_inspector_expand-collapse.js#31
Attachment #8769342 - Flags: review?(bgrinstead)
(Assignee)

Comment 3

a year ago
Created attachment 8769353 [details] [diff] [review]
inspector-menu-fix.patch

add test case
Attachment #8769342 - Attachment is obsolete: true
Attachment #8769353 - Flags: review?(bgrinstead)
Comment on attachment 8769353 [details] [diff] [review]
inspector-menu-fix.patch

Review of attachment 8769353 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a green try push
Attachment #8769353 - Flags: review?(bgrinstead) → review+
(Assignee)

Comment 5

a year ago
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ca56c58d808
Status: NEW → ASSIGNED
Iteration: --- → 50.3 - Jul 18
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 6

a year ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/1c50c021b152
Do not disable 'expand all' option in inspector context menu if a node is selected; r=bgrins
Keywords: checkin-needed

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1c50c021b152
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50

Comment 8

a year ago
Reproduced with 50.0a1 from 2016-07-06 under Windows 10 64-bit.
Verified fixed with latest Nightly 50.0a1 (from 2016-07-13), across platforms [1]. 

Although, why isn't 'Expand all' context menu option disabled when all the nodes are already expanded? For instance, 'Collapse' is disable when no nodes are expanded. 

[1] Ubuntu 16.04 64-bit, Windows 10 64-bit and Mac OS X 10.11.1
Status: RESOLVED → VERIFIED
QA Whiteboard: [qe-dthtml]
status-firefox50: fixed → verified
Flags: qe-verify+ → needinfo?(mvonbriesen)
(Assignee)

Comment 9

a year ago
This patch was just to preserve the pre-regression behavior. The expand all behavior could still be improved, like you said. Could you please file a new bug for that?
Flags: needinfo?(mvonbriesen)

Comment 10

a year ago
(In reply to Maximillian von Briesen [:moby] from comment #9)
>Could you please file a new bug for that?
Sure thing! Logged bug 1286812.
You need to log in before you can comment on or make changes to this bug.