1283742 - Share to wechat is invalid

Status: VERIFIED FIXED

(Firefox for iOS :: Browser, defect)

Description

[lyang]

Share to wechat is invalid. Because wechat can't identify 1password extension UIT.

Comment 1

[lyang]

Attachment: pull request

Comment 2

[lyang]

Comment on attachment 8767060 [details] [review]
pull request

https://github.com/mozilla/firefox-ios/pull/1980

Comment 3

[lyang]

Attachment: pull request

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8785202 [details] [review]
pull request

I'm not too familiar with how our sharing code works but I feel like this will effect other extensions - not just WeChat. Does this make sense?

Comment 5

[Emily Toop (:fluffyemily)]

:jhugman is definitely the person to answer this one.

Comment 6

[James Hugman [:jhugman] [@jhugman]]

So the patch here feels like it's a workaround rather than the fix.

I'd like to understand why our custom uti conforms to public.url but wechat doesn't recognize that. Do other apps correctly understand behave (and thus its wechat's bug) or is it ours?

(perhaps writing a test application might help here).

Also: how does this perform in the presence of both wechat and a password manager?



https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Info.plist#L127

Comment 7

[lyang]

(In reply to James Hugman [:jhugman] [@jhugman] from comment #6)
I totally agree with you. Our custom uti conforms to public.url, but WeChat doesn’t recognize that. It is feels like wechat’s bug.

But in China, we only have a small number of users, and WeChat is really popular, so we need fix this bug for ourselves.

And I have changed my patch, just compatible with the WeChat. Please help me review it.

(I do not know how to write test application. Could you tell me more detail about this?)

Comment 8

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 9

[Farhan Patel [:farhan]]

Thanks for fixing this Lin. And sorry for taking so long. There were some slight changes I had to make so I created a new PR and incorporated your fix. 

https://github.com/mozilla-mobile/firefox-ios/commit/6f1e1680641349835df77865dd6419a49461e9c0

Comment 10

[Stephan Leroux [:sleroux]]

v6.x a03c6bc

Comment 11

[Simon Basca [:SimonB]]

Tested on 6.0b3 on devices running iOS 9 and 10.

The content can now be shared to WeChat.