Closed Bug 1283785 Opened 9 years ago Closed 9 years ago

Some more NextFrameSeekTask refactoring

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(4 files)

No description provided.
Mass change P2 -> P3
Priority: P2 → P3
Assignee: nobody → jwwang
Blocks: 1283751
1. EnsureVideoDecodeTaskQueued() is called from video callbaks where IsVideoRequestPending() is false. 2. EnsureVideoDecodeTaskQueued() is called from Seek() which checks IsVideoRequestPending() is false. Review commit: https://reviewboard.mozilla.org/r/63624/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63624/
Attachment #8769998 - Flags: review?(kaku)
Attachment #8769999 - Flags: review?(kaku)
Attachment #8770000 - Flags: review?(kaku)
Attachment #8770001 - Flags: review?(kaku)
EnsureVideoDecodeTaskQueued() is always called when NeedMoreVideo() is true which guarantees mIsVideoQueueFinished is false and IsVideoDecoding() is true. Review commit: https://reviewboard.mozilla.org/r/63626/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63626/
Comment on attachment 8769998 [details] Bug 1283785. Part 1 - remove the IsVideoRequestPending() check from EnsureVideoDecodeTaskQueued() https://reviewboard.mozilla.org/r/63624/#review60542
Attachment #8769998 - Flags: review?(kaku) → review+
Attachment #8769999 - Flags: review?(kaku) → review+
Comment on attachment 8769999 [details] Bug 1283785. Part 2 - remove the IsVideoDecoding() check from EnsureVideoDecodeTaskQueued(). https://reviewboard.mozilla.org/r/63626/#review60544
Attachment #8770000 - Flags: review?(kaku) → review+
Comment on attachment 8770001 [details] Bug 1283785. Part 4 - remove unused macros and fix some styles. https://reviewboard.mozilla.org/r/63630/#review60548
Attachment #8770001 - Flags: review?(kaku) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c4ef689d5b5c Part 1 - remove the IsVideoRequestPending() check from EnsureVideoDecodeTaskQueued() r=kaku https://hg.mozilla.org/integration/autoland/rev/a1d2e88f5ff4 Part 2 - remove the IsVideoDecoding() check from EnsureVideoDecodeTaskQueued(). r=kaku https://hg.mozilla.org/integration/autoland/rev/41a7b386d049 Part 3 - merge and remove unused functions. r=kaku https://hg.mozilla.org/integration/autoland/rev/477b98f9600e Part 4 - remove unused macros and fix some styles. r=kaku
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: