1283785 - Some more NextFrameSeekTask refactoring

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mass change P2 -> P3

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1283785. Part 1 - remove the IsVideoRequestPending() check from EnsureVideoDecodeTaskQueued()

1. EnsureVideoDecodeTaskQueued() is called from video callbaks where IsVideoRequestPending() is false.
2. EnsureVideoDecodeTaskQueued() is called from Seek() which checks IsVideoRequestPending() is false.

Review commit: https://reviewboard.mozilla.org/r/63624/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63624/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1283785. Part 2 - remove the IsVideoDecoding() check from EnsureVideoDecodeTaskQueued().

EnsureVideoDecodeTaskQueued() is always called when NeedMoreVideo() is true which
guarantees mIsVideoQueueFinished is false and IsVideoDecoding() is true.

Review commit: https://reviewboard.mozilla.org/r/63626/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63626/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1283785. Part 3 - merge and remove unused functions.

Review commit: https://reviewboard.mozilla.org/r/63628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63628/

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1283785. Part 4 - remove unused macros and fix some styles.

Review commit: https://reviewboard.mozilla.org/r/63630/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63630/

Comment 6

[Tzuhao Kuo [:kaku]]

Comment on attachment 8769998 [details]
Bug 1283785. Part 1 - remove the IsVideoRequestPending() check from EnsureVideoDecodeTaskQueued()

https://reviewboard.mozilla.org/r/63624/#review60542

Comment 7

[Tzuhao Kuo [:kaku]]

Comment on attachment 8769999 [details]
Bug 1283785. Part 2 - remove the IsVideoDecoding() check from EnsureVideoDecodeTaskQueued().

https://reviewboard.mozilla.org/r/63626/#review60544

Comment 8

[Tzuhao Kuo [:kaku]]

Comment on attachment 8770000 [details]
Bug 1283785. Part 3 - merge and remove unused functions.

https://reviewboard.mozilla.org/r/63628/#review60546

Comment 9

[Tzuhao Kuo [:kaku]]

Comment on attachment 8770001 [details]
Bug 1283785. Part 4 - remove unused macros and fix some styles.

https://reviewboard.mozilla.org/r/63630/#review60548

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4ef689d5b5c
Part 1 - remove the IsVideoRequestPending() check from EnsureVideoDecodeTaskQueued() r=kaku
https://hg.mozilla.org/integration/autoland/rev/a1d2e88f5ff4
Part 2 - remove the IsVideoDecoding() check from EnsureVideoDecodeTaskQueued(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/41a7b386d049
Part 3 - merge and remove unused functions. r=kaku
https://hg.mozilla.org/integration/autoland/rev/477b98f9600e
Part 4 - remove unused macros and fix some styles. r=kaku

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c4ef689d5b5c
https://hg.mozilla.org/mozilla-central/rev/a1d2e88f5ff4
https://hg.mozilla.org/mozilla-central/rev/41a7b386d049
https://hg.mozilla.org/mozilla-central/rev/477b98f9600e