Status
()
People
(Reporter: jwwang, Assigned: jwwang)
Tracking
Firefox Tracking Flags
(firefox50 fixed)
Details
MozReview Requests
()
| Submitter | Diff | Changes | Open Issues | Last Updated |
|---|---|---|---|---|
| Loading... | ||||
| Error loading review requests: | ||||
Attachments
(4 attachments)
| Comment hidden (empty) |
|
||
Updated•2 years ago
|
||
Priority: -- → P2
|
(Assignee) | |
Comment 2•2 years ago
|
||
Created attachment 8769998 [details] Bug 1283785. Part 1 - remove the IsVideoRequestPending() check from EnsureVideoDecodeTaskQueued() 1. EnsureVideoDecodeTaskQueued() is called from video callbaks where IsVideoRequestPending() is false. 2. EnsureVideoDecodeTaskQueued() is called from Seek() which checks IsVideoRequestPending() is false. Review commit: https://reviewboard.mozilla.org/r/63624/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63624/
Attachment #8769998 -
Flags: review?(kaku)
Attachment #8769999 -
Flags: review?(kaku)
Attachment #8770000 -
Flags: review?(kaku)
Attachment #8770001 -
Flags: review?(kaku)
|
|
(Assignee) | |
Comment 3•2 years ago
|
||
Created attachment 8769999 [details] Bug 1283785. Part 2 - remove the IsVideoDecoding() check from EnsureVideoDecodeTaskQueued(). EnsureVideoDecodeTaskQueued() is always called when NeedMoreVideo() is true which guarantees mIsVideoQueueFinished is false and IsVideoDecoding() is true. Review commit: https://reviewboard.mozilla.org/r/63626/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63626/
|
|
(Assignee) | |
Comment 4•2 years ago
|
||
Created attachment 8770000 [details] Bug 1283785. Part 3 - merge and remove unused functions. Review commit: https://reviewboard.mozilla.org/r/63628/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63628/
|
|
(Assignee) | |
Comment 5•2 years ago
|
||
Created attachment 8770001 [details] Bug 1283785. Part 4 - remove unused macros and fix some styles. Review commit: https://reviewboard.mozilla.org/r/63630/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63630/
|
||
Comment 6•2 years ago
|
||
Comment on attachment 8769998 [details] Bug 1283785. Part 1 - remove the IsVideoRequestPending() check from EnsureVideoDecodeTaskQueued() https://reviewboard.mozilla.org/r/63624/#review60542
Attachment #8769998 -
Flags: review?(kaku) → review+
|
|
||
Updated•2 years ago
|
||
Attachment #8769999 -
Flags: review?(kaku) → review+
|
|
||
Comment 7•2 years ago
|
||
Comment on attachment 8769999 [details] Bug 1283785. Part 2 - remove the IsVideoDecoding() check from EnsureVideoDecodeTaskQueued(). https://reviewboard.mozilla.org/r/63626/#review60544
|
|
||
Comment 8•2 years ago
|
||
Comment on attachment 8770000 [details] Bug 1283785. Part 3 - merge and remove unused functions. https://reviewboard.mozilla.org/r/63628/#review60546
Attachment #8770000 -
Flags: review?(kaku) → review+
|
|
||
Comment 9•2 years ago
|
||
Comment on attachment 8770001 [details] Bug 1283785. Part 4 - remove unused macros and fix some styles. https://reviewboard.mozilla.org/r/63630/#review60548
Attachment #8770001 -
Flags: review?(kaku) → review+
|
|
(Assignee) | |
Comment 10•2 years ago
|
||
Thanks for the review!
|
||
Comment 11•2 years ago
|
||
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c4ef689d5b5c Part 1 - remove the IsVideoRequestPending() check from EnsureVideoDecodeTaskQueued() r=kaku https://hg.mozilla.org/integration/autoland/rev/a1d2e88f5ff4 Part 2 - remove the IsVideoDecoding() check from EnsureVideoDecodeTaskQueued(). r=kaku https://hg.mozilla.org/integration/autoland/rev/41a7b386d049 Part 3 - merge and remove unused functions. r=kaku https://hg.mozilla.org/integration/autoland/rev/477b98f9600e Part 4 - remove unused macros and fix some styles. r=kaku
|
||
Comment 12•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c4ef689d5b5c https://hg.mozilla.org/mozilla-central/rev/a1d2e88f5ff4 https://hg.mozilla.org/mozilla-central/rev/41a7b386d049 https://hg.mozilla.org/mozilla-central/rev/477b98f9600e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.