1283865 - remove pattern restrictions on display fields of pulse jobs

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect)

Description

[Cameron Dawson [:camd]]

We had imposed some regex requirements for fields like job_symbol, job_name, group_symbol, group_name.  The jobs would be rejected if they didn't conform.  However, there's no way, at this time, to provide guidance to task definition developers on how to conform to those.  Would need some kind of tool to run their definition against our regexes and provide feedback.  

For now, we should just remove these pattern requirements because they're causing jobs to be rejected on ingestion due to non-conformance.

I hate to punt on this, but the precedence is that this is the stage we're currently in.  Jobs come to Treeherder without these pattern matching anyway.  I'll create a separate bug to develop a way to have restrictions and help people conform to them.

Comment 1

[Ed Morley [:emorley]]

I'm presuming the problem is that by the time the jobs are in the Pulse queue it's too late to inform the submitter. ie: something more upstream (in taskcluster/wherever) needs to do the validation too?

Presumably in the future we can get taskcluster to just use our published jsonschema files to validate the metadata upstream?

Comment 2

[Cameron Dawson [:camd]]

created bug 1283866 in Taskcluster for that tool/workflow.

Comment 3

[Cameron Dawson [:camd]]

Ed: exactly.  And we have quite a number of jobs that are already out of compliance with what we'd like.  We can modify the regexes to accommodate them, but a new task developer will probably run into something else we hadn't thought of.

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:remove-patterns-pulse-display > mozilla:master

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8e3e5b7518571cee32e60219ffc81165e685303a
Bug 1283865 - remove pattern requirements for pulse job display fields (#1639)

Several existing jobs are already out of compliance with these patterns
and there is no existing way to tell task definition developers how to
comply with our required patterns.

created bug 1283866 in Taskcluster for that tool/workflow

This removes the pattern requirements.  If we ever decide that we DO
need these patterns, we can create that tool and then fix old task
definitions to comply.