1283916 - Incomplete symbolification of js::

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

For some reason, some crashes end up with a frame where the signature is just "js::".

Here's an example:
https://crash-stats.mozilla.com/report/index/b27d8452-2dfd-405f-af75-82b0a2160617

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

It looks like these are all on OSX.

Comment 2

[(not currently active) Ted Mielczarek]

I think this is just the bug I fixed in:
https://chromium.googlesource.com/breakpad/breakpad/+/2e266396ee14f3c00252863704716b0e4b0fc3f0

Comment 3

[(not currently active) Ted Mielczarek]

...although maybe that hasn't landed in mozilla-central.

Comment 4

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Great! That certainly looks like the issue here. Fortunately for now it seems like these are all the same crash.

Comment 5

[(not currently active) Ted Mielczarek]

I have a bug open to update our in-tree Breakpad (bug 1264367) but my try push showed some things that need to be fixed, so we should just cherry-pick that patch from upstream for now.

Comment 6

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1162349b49cb3a0107ae6ea07164fc9e94b7cc1
bug 1283916 - Fix DWARF handling of inlined functions in namespaces. r=mento

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a1162349b49c

Comment 8

[(not currently active) Ted Mielczarek]

We could uplift this patch if you'd like, it's pretty innocuous and only touches code in dump_syms, not code we ship. This also isn't a high-volume crash, though.

Comment 9

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Yeah, it is probably okay to not bother uplifting it for now.