1284021 - checksetup.pl spins in an infinite loop when denied terminal input and no admin login is provided

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P1)

Description

[Dylan Hardison [:dylan] (he/him)]

In the case where you provide a checksetup answers file, and that file doesn't provide, say, a login name or an email, checksetup will keep asking. There are several ways of solving this (a counter, for instance. Or checking if we can read from STDIN. Or if STDIN is a terminal)

Comment 1

[Dylan Hardison [:dylan] (he/him)]

The code in question is here: https://github.com/bugzilla/bugzilla/blob/master/Bugzilla/Install.pm#L334-L370
Checking for eof on STDIN would be helpful. Or having a max number of times the while loops can run.

Note that checking -t is probably bad as someone (like me) may run this from emacs shell mode
which is not a "real" terminal. Probably a combination of eof testing and a counter is the best bet.

Comment 2

[GitHub Autolander Bot]

Attachment: [bugzilla] spoonyspork:master > bugzilla:master

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8767441 [details] [review]
[bugzilla] spoonyspork:master > bugzilla:master

It wouldn't be appropriate for me to review this patch.

(disclosure: spoonyspork is my wife)

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8767441 [details] [review]
[bugzilla] spoonyspork:master > bugzilla:master

r=dkl

Comment 5

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:bugzilla/bugzilla
   5880669..8afe38b  master -> master