Closed Bug 1284051 Opened 4 years ago Closed 4 years ago

Crash in mozilla::layers::PLayerTransactionChild::Manager const

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Platform:
Unspecified
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- verified

People

(Reporter: marcia, Assigned: nical)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

Null-check GetCompositorBridgeChild
1.76 KB, patch
sotaro
: review+
Details | Diff | Splinter Review 
This bug was filed from the Socorro interface and is 
report bp-d71fc3c2-f59f-4925-94f5-aacd42160703.
=============================================================

Seen while looking at nightly crash stats. Low volume Mac crash that started with 20160630030207: http://bit.ly/29iAEtu.

ni on nsilva since it appears he worked in that area and can maybe help figure out if I placed this in the right component.
Flags: needinfo?(nical.bugzilla)
We already check HasShadowManager() in most places, except in GetCompositorBridgeChild and its callers.
Assignee: nobody → nical.bugzilla
Flags: needinfo?(nical.bugzilla)
Attachment #8767616 - Flags: review?(sotaro.ikeda.g)
Attachment #8767616 - Flags: review?(sotaro.ikeda.g) → review+
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/276344b08697
Handle ShadowLayers::GetCompositorBridgeChild returning null. r=sotaro
https://hg.mozilla.org/mozilla-central/rev/276344b08697
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
I believe we can safely mark this verified fixed on Fx50, based on the crash
stats available for the last 2 months.

  SIGNATURE   | mozilla::layers::PLayerTransactionChild::Manager const
  --------------------------------------------------------------------
  CRASH STATS | http://tinyurl.com/jcwv2sf
  --------------------------------------------------------------------
  OVERVIEW    | 0 crashes on nightly 50
	      | 0 crashes on aurora 50
	      | 0 crashes on beta 50
Status: RESOLVED → VERIFIED
status-firefox50: fixed → verified
You need to log in before you can comment on or make changes to this bug.