Closed
Bug 1284202
Opened 8 years ago
Closed 8 years ago
Add deprecation warning for SEC_NORMAL
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
1.24 KB,
patch
|
tanvi
:
review+
|
Details | Diff | Splinter Review |
We should not use SEC_NORMAL within the loadInfo anymore, we should use one of the following 5 flags: SEC_REQUIRE_SAME_ORIGIN_DATA_INHERITS SEC_REQUIRE_SAME_ORIGIN_DATA_IS_BLOCKED SEC_ALLOW_CROSS_ORIGIN_DATA_INHERITS SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL SEC_REQUIRE_CORS_DATA_INHERITS
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8767591 -
Flags: review?(tanvi)
Comment 2•8 years ago
|
||
Comment on attachment 8767591 [details] [diff] [review] bug_1284202_deprecation_warning_sec_normal.patch r+ but we can't land this yet because of http://searchfox.org/mozilla-central/source/docshell/base/nsDocShell.cpp#10790
Attachment #8767591 -
Flags: review?(tanvi) → review+
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Tanvi Vyas - behind on reviews [:tanvi] from comment #2) > Comment on attachment 8767591 [details] [diff] [review] > bug_1284202_deprecation_warning_sec_normal.patch > > r+ but we can't land this yet because of > http://searchfox.org/mozilla-central/source/docshell/base/nsDocShell. > cpp#10790 I think we can, I just don't want anyone creating a new channel (loadinfo) using this flag anymore. Thanks Tanvi!
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d7cddb7c5b31 Add deprecation warning for SEC_NORMAL. r=tanvi
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d7cddb7c5b31
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment 6•8 years ago
|
||
Ah right, this just adds a comment. Thanks Chris!
You need to log in
before you can comment on or make changes to this bug.
Description
•