1284203 - Flash's "Ask to activate" prompt is triggered on all tabs, including unrelated ones

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect)

Description

[Fanolian]

Attachment: Click-to-play prompt on Firefox firstrun page.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160703030210

Steps to reproduce:

0. Install Flash Player 22.0.0.192 (current version) on the system.
1. In a new profile, set Flash to "Ask to Activate".
2. Open a few dummy pages with no Flash contents, e.g. https://www.mozilla.org/en-US/firefox/nightly/firstrun/, https://www.mozilla.org/en-US/firefox/windows-10/welcome/. Check that there is no click-to-play prompts for now on location bars on these tabs.
3. Open a new tab, visit https://www.adobe.com/software/flash/about/ to trigger a click-to-play prompt.
4. Switch back to those dummy pages at step 2.


Actual results:

Click-to-play prompt appears on all unrelated tabs which do not have any Flash contents. (see attachment)

Reloading dummy pages can untrigger the prompt. But reloading the Adobe page, which contains Flash contents, will make all prompts at all tabs come back.


Expected results:

Click-to-play prompt should be triggered on affected page only.

Comment 1

[Fanolian]

From mozregression:
Last good Nightly: 2016-06-30
First bad Nightly: 2016-07-01
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d700dc054751333e0735f975fce3d3adf153c62a&tochange=fdcee57b4e4f66a82831ab01e61500da98a858e8

Further bisection:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=80c7885e432cec558c128379d2fb86d9935fb0ad&tochange=aa4557a5485fd8266f3f529d979215e296afac97

Suspect: But 1186948

I don't seem to recall such issue when the patch first landed, but backed-out, in early June. (bug 1186948 comment 26)

Comment 2

[Fanolian]

Attachment: Click-to-play prompt on system tabs.PNG

The bug is even worse on my main profile. If I log in to https://www.inoreader.com/, click-to-play prompts are triggered on _all_ tabs, including system tabs like about:addons, about:home, about:newtab.
However, I cannot reproduce this on new profiles.

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Here's the problem: http://searchfox.org/mozilla-central/rev/ffcc65db736dd64dc3cbc49592f9edac77bf65ad/browser/modules/PluginContent.jsm#126

The Plugin::HiddenPluginTouched observer notification is firing, and so _every_ tab is sending up the click-to-play message to the parent.

blassey is likely on holiday today due to July 4th. I think I'm going to back bug 1186948 out so we can take care of it once he gets back.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b295ee49d52ebb1b0e20bcf4d111b6b6294a85ca
Backed out changeset aa4557a5485f for causing bug 1284203.

https://hg.mozilla.org/integration/mozilla-inbound/rev/22c4e1bae9775e8765d1180ff4795b3a61b0f699
Backed out changeset 776f0bb21587 for causing bug 1284203.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b295ee49d52e
https://hg.mozilla.org/mozilla-central/rev/22c4e1bae977

Comment 7

[Benjamin Smedberg]

Resolved via backout.

Comment 8

[Marcia Knous [:marcia]]

Removing tracking nom flag as the offending bug has been backed out and the issue should be resolved.