Upgrade AngularJS to 1.4.9 and AngularUI Bootstrap to 1.3.3

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: crosscent, Assigned: crosscent)

Tracking

Details

Attachments

(3 attachments)

(Assignee)

Description

a year ago
Angular bootstrap 1.3.3 has some features that would be nice to have in. For example, boundary-link-numbers for uib-pagination.
(Assignee)

Comment 1

a year ago
Angular bootstrap 1.3.3 requires $q.resolve, which is only available on AngularJS 1.4.5 or above. 

emorley, and wlach have suggested that we upgrade to the latest version in 1.4, which is 1.4.9.

Comment 2

a year ago
Created attachment 8767715 [details] [review]
[treeherder] crosscent:Bug1284275 > mozilla:master
(Assignee)

Updated

a year ago
Attachment #8767715 - Flags: review?(wlachance)
Comment on attachment 8767715 [details] [review]
[treeherder] crosscent:Bug1284275 > mozilla:master

Looks good to me. I would personally separate this into two commits (one to bump the angular version, another to bump angular bootstrap) but it's not that big a deal. Let's just get this landed so you can continue working. :)
Attachment #8767715 - Flags: review?(wlachance) → review+

Comment 4

a year ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b1a82fba5563248340869c40d4bb042b67b0deb2
Bug 1284275 - Upgrade AngularJS and it's dependencies to 1.4.9, and upgrade AngularUI Bootstrap to 1.3.3 (#1644)
Did some preliminary testing and this looks ok. I think it's a pretty low risk change, but we should run moztrap before the next deploy just to be sure.
Assignee: nobody → crosscent
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED

Updated

a year ago
Summary: Upgrade angular bootstrap to 1.3.3 → Upgrade AngularJS to 1.4.9 and AngularUI Bootstrap to 1.3.3

Comment 6

a year ago
Created attachment 8770651 [details] [review]
[treeherder] wlach:1284275-2 > mozilla:master

Comment 7

a year ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/eb91d078300e7392cd01d63a67f76ab9a9103ccf
Bug 1284275 - Fix modal dialogs in perfherder alert views (#1683)

Comment 8

a year ago
Created attachment 8771387 [details] [review]
[treeherder] wlach:1284275-3 > mozilla:master

Comment 9

a year ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/7b08f1e916ba62574eed5f92aa506aa5de25250a
Bug 1284275 - Another fix for reassign perf alerts dialog (#1693)
You need to log in before you can comment on or make changes to this bug.