Closed Bug 1284281 Opened 3 years ago Closed 3 years ago

Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: michael.li11702, Assigned: michael.li11702)

Details

Attachments

(1 file, 3 obsolete files)

No description provided.
Assignee: nobody → mili
Attachment #8767706 - Flags: review?(tbsaunde+mozbugs)
Comment on attachment 8767706 [details] [diff] [review]
Add mHasHyperLink to ProxyAccessible class

># HG changeset patch
># User Michael Li <michael.li11702@gmail.com>
>
>bug 1284281 - Add mHasHyperLink to ProxyAccessible class

a better commit message would say what you are trying to achieve, and maybe why you do it this way.

So start with something like "support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink".  Then if you feel like explain the approach by saying we need to store the bit in the proxy to know what it is when the xpcAccessible gets created later, but maybe its not worth adding that here.

>   // documents.
>   role mRole : 29;

you should take away a bit here so this set of bit fields stays 32 bits.

>   if (aProxy->mHasValue) {
>     interfaces |= eValue;
>   }
>+  if (aProxy->mHasHyperLink) {

blank line after } please
Attachment #8767706 - Flags: review?(tbsaunde+mozbugs) → review+
Attachment #8767766 - Flags: review?(tbsaunde+mozbugs)
Summary: Add mHasHyperLink to ProxyAccessible class → Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink
Comment on attachment 8767766 [details] [diff] [review]
Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink

>-     mHasValue(aInterfaces & Interfaces::VALUE)
>+     mHasValue(aInterfaces & Interfaces::VALUE),
>+     mHasHyperLink(aInterfaces & Interfaces::HYPERLINK)

mIsHyperLink would make a little more sense I think sorry I didn't catch that last time.
Attachment #8767766 - Flags: review?(tbsaunde+mozbugs) → review+
Keywords: checkin-needed
Attachment #8767766 - Attachment is obsolete: true
The second patch doesn't apply cleanly (please mark obsolete patches as such if they aren't needed anymore).
Keywords: checkin-needed
Attachment #8767706 - Attachment is obsolete: true
Thanks for your help Ryan!
Attachment #8768805 - Flags: review+
Attachment #8768805 - Attachment description: Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink → Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde
Keywords: checkin-needed
Attachment #8768805 - Attachment description: Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde → Bug 1284281 - Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efe1b56a4e0f
Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/efe1b56a4e0f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Attachment #8769826 - Flags: review?(tbsaunde+mozbugs)
Pushed commit to wrong bug, my bad.
Attachment #8769826 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.