Closed
Bug 1284281
Opened 8 years ago
Closed 8 years ago
Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: michael.li11702, Assigned: michael.li11702)
Details
Attachments
(1 file, 3 obsolete files)
2.60 KB,
patch
|
michael.li11702
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mili
Assignee | ||
Updated•8 years ago
|
Attachment #8767706 -
Flags: review?(tbsaunde+mozbugs)
Comment 2•8 years ago
|
||
Comment on attachment 8767706 [details] [diff] [review] Add mHasHyperLink to ProxyAccessible class ># HG changeset patch ># User Michael Li <michael.li11702@gmail.com> > >bug 1284281 - Add mHasHyperLink to ProxyAccessible class a better commit message would say what you are trying to achieve, and maybe why you do it this way. So start with something like "support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink". Then if you feel like explain the approach by saying we need to store the bit in the proxy to know what it is when the xpcAccessible gets created later, but maybe its not worth adding that here. > // documents. > role mRole : 29; you should take away a bit here so this set of bit fields stays 32 bits. > if (aProxy->mHasValue) { > interfaces |= eValue; > } >+ if (aProxy->mHasHyperLink) { blank line after } please
Attachment #8767706 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8767766 -
Flags: review?(tbsaunde+mozbugs)
Assignee | ||
Updated•8 years ago
|
Summary: Add mHasHyperLink to ProxyAccessible class → Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink
Comment 4•8 years ago
|
||
Comment on attachment 8767766 [details] [diff] [review] Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink >- mHasValue(aInterfaces & Interfaces::VALUE) >+ mHasValue(aInterfaces & Interfaces::VALUE), >+ mHasHyperLink(aInterfaces & Interfaces::HYPERLINK) mIsHyperLink would make a little more sense I think sorry I didn't catch that last time.
Attachment #8767766 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Updated•8 years ago
|
Attachment #8767766 -
Attachment is obsolete: true
Comment 6•8 years ago
|
||
The second patch doesn't apply cleanly (please mark obsolete patches as such if they aren't needed anymore).
Keywords: checkin-needed
Assignee | ||
Updated•8 years ago
|
Attachment #8767706 -
Attachment is obsolete: true
Assignee | ||
Comment 7•8 years ago
|
||
Thanks for your help Ryan!
Assignee | ||
Updated•8 years ago
|
Attachment #8768805 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Attachment #8768805 -
Attachment description: Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink → Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•8 years ago
|
Attachment #8768805 -
Attachment description: Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde → Bug 1284281 - Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/efe1b56a4e0f Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde
Keywords: checkin-needed
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/efe1b56a4e0f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Assignee | ||
Comment 10•8 years ago
|
||
Attachment #8769826 -
Flags: review?(tbsaunde+mozbugs)
Assignee | ||
Updated•8 years ago
|
Attachment #8769826 -
Flags: review?(tbsaunde+mozbugs)
Assignee | ||
Comment 11•8 years ago
|
||
Pushed commit to wrong bug, my bad.
Assignee | ||
Updated•8 years ago
|
Attachment #8769826 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•