Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink

RESOLVED FIXED in Firefox 50

Status

()

Core
Disability Access APIs
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Michael Li, Assigned: Michael Li)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8767706 [details] [diff] [review]
Add mHasHyperLink to ProxyAccessible class
(Assignee)

Updated

2 years ago
Assignee: nobody → mili
(Assignee)

Updated

2 years ago
Attachment #8767706 - Flags: review?(tbsaunde+mozbugs)
Comment on attachment 8767706 [details] [diff] [review]
Add mHasHyperLink to ProxyAccessible class

># HG changeset patch
># User Michael Li <michael.li11702@gmail.com>
>
>bug 1284281 - Add mHasHyperLink to ProxyAccessible class

a better commit message would say what you are trying to achieve, and maybe why you do it this way.

So start with something like "support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink".  Then if you feel like explain the approach by saying we need to store the bit in the proxy to know what it is when the xpcAccessible gets created later, but maybe its not worth adding that here.

>   // documents.
>   role mRole : 29;

you should take away a bit here so this set of bit fields stays 32 bits.

>   if (aProxy->mHasValue) {
>     interfaces |= eValue;
>   }
>+  if (aProxy->mHasHyperLink) {

blank line after } please
Attachment #8767706 - Flags: review?(tbsaunde+mozbugs) → review+
(Assignee)

Comment 3

2 years ago
Created attachment 8767766 [details] [diff] [review]
Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink
Attachment #8767766 - Flags: review?(tbsaunde+mozbugs)
(Assignee)

Updated

2 years ago
Summary: Add mHasHyperLink to ProxyAccessible class → Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink
Comment on attachment 8767766 [details] [diff] [review]
Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink

>-     mHasValue(aInterfaces & Interfaces::VALUE)
>+     mHasValue(aInterfaces & Interfaces::VALUE),
>+     mHasHyperLink(aInterfaces & Interfaces::HYPERLINK)

mIsHyperLink would make a little more sense I think sorry I didn't catch that last time.
Attachment #8767766 - Flags: review?(tbsaunde+mozbugs) → review+
(Assignee)

Comment 5

2 years ago
Created attachment 8768805 [details] [diff] [review]
Bug 1284281 - Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
Attachment #8767766 - Attachment is obsolete: true
The second patch doesn't apply cleanly (please mark obsolete patches as such if they aren't needed anymore).
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Attachment #8767706 - Attachment is obsolete: true
(Assignee)

Comment 7

2 years ago
Thanks for your help Ryan!
(Assignee)

Updated

2 years ago
Attachment #8768805 - Flags: review+
(Assignee)

Updated

2 years ago
Attachment #8768805 - Attachment description: Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink → Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Attachment #8768805 - Attachment description: Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde → Bug 1284281 - Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde

Comment 8

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efe1b56a4e0f
Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde
Keywords: checkin-needed

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/efe1b56a4e0f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
(Assignee)

Comment 10

2 years ago
Created attachment 8769826 [details] [diff] [review]
Change various classes to use new role map index functions and updated BindToDocument function. r?tbsaunde
Attachment #8769826 - Flags: review?(tbsaunde+mozbugs)
(Assignee)

Updated

2 years ago
Attachment #8769826 - Flags: review?(tbsaunde+mozbugs)
(Assignee)

Comment 11

2 years ago
Pushed commit to wrong bug, my bad.
(Assignee)

Updated

2 years ago
Attachment #8769826 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.