[webvr] Allow GLScreenBuffer::CreateFactory to work without a CompositableForwarder

RESOLVED FIXED in Firefox 50

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kip, Assigned: kip)

Tracking

unspecified
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
While implementing the WebVR 1.0 API (Bug 1250244), I am using parts of the gfx stack and do not wish to pull in dependencies such as layers.

This patch updates GLScreenBuffer to allow use without a CompositableForwarder.
Assignee

Comment 2

3 years ago
- GLScreenBuffer::CreateFactory has been overloaded to accept either
  a CompositableForwarder or a ClientIPCAllocator.
- WebVR 1.0 API implementation in Bug 1250244 uses GLScreenBuffer
  without a CompositableForwarder.

Review commit: https://reviewboard.mozilla.org/r/62142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62142/
Assignee

Updated

3 years ago
Attachment #8767735 - Flags: review?(gwright)
Assignee

Comment 3

3 years ago
I am splitting Bug 1250244 into easier to review and land pieces such as this one.

Please let me know if another reviewer would be a better choice, thanks!
Comment on attachment 8767735 [details]
Bug 1284292 - Allow GLScreenBuffer::CreateFactory to work without a CompositableForwarder

https://reviewboard.mozilla.org/r/62142/#review58926
Attachment #8767735 - Flags: review?(gwright) → review+

Comment 5

3 years ago
Pushed by kgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26cf02eec830
Allow GLScreenBuffer::CreateFactory to work without a CompositableForwarder r=gw280

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/26cf02eec830
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.