1284292 - [webvr] Allow GLScreenBuffer::CreateFactory to work without a CompositableForwarder

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[:kip (Kearwood Gilbert)]

While implementing the WebVR 1.0 API (Bug 1250244), I am using parts of the gfx stack and do not wish to pull in dependencies such as layers.

This patch updates GLScreenBuffer to allow use without a CompositableForwarder.

Comment 1

[:kip (Kearwood Gilbert)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=58a698078f9d

Comment 2

[:kip (Kearwood Gilbert)]

Attachment: Bug 1284292 - Allow GLScreenBuffer::CreateFactory to work without a CompositableForwarder

- GLScreenBuffer::CreateFactory has been overloaded to accept either
  a CompositableForwarder or a ClientIPCAllocator.
- WebVR 1.0 API implementation in Bug 1250244 uses GLScreenBuffer
  without a CompositableForwarder.

Review commit: https://reviewboard.mozilla.org/r/62142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62142/

Comment 3

[:kip (Kearwood Gilbert)]

I am splitting Bug 1250244 into easier to review and land pieces such as this one.

Please let me know if another reviewer would be a better choice, thanks!

Comment 4

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8767735 [details]
Bug 1284292 - Allow GLScreenBuffer::CreateFactory to work without a CompositableForwarder

https://reviewboard.mozilla.org/r/62142/#review58926

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26cf02eec830
Allow GLScreenBuffer::CreateFactory to work without a CompositableForwarder r=gw280

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/26cf02eec830