1284324 - [webvr] Implement Canvas Layer Mirrors

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[:kip (Kearwood Gilbert)]

- When a canvas layer is set to mirror, it copies the
  texture from the canvas rather than changing the
  texture factory with Morph().
- This is useful when a canvas content will be sent to
  multiple devices simultaneously, such as a VR HMD
  and a 2d monitor mirror.

Comment 1

[:kip (Kearwood Gilbert)]

Attachment: Bug 1284324 - Implement Canvas Layer mirrors

- When a canvas layer is set to mirror, it copies the
  texture from the canvas rather than changing the
  texture factory with Morph().
- This is useful when a canvas content will be sent to
  multiple devices simultaneously, such as a VR HMD
  and a 2d monitor mirror.
- This is used by the WebVR 1.0 API, in Bug 1250244

Review commit: https://reviewboard.mozilla.org/r/62162/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62162/

Comment 2

[:kip (Kearwood Gilbert)]

I am splitting Bug 1250244 into easier to review and land pieces such as this one.

Please let me know if another reviewer would be a better choice, thanks!

Comment 3

[:kip (Kearwood Gilbert)]

Comment on attachment 8767754 [details]
Bug 1284324 - Implement Canvas Layer mirrors

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/62162/diff/1-2/

Comment 4

[:kip (Kearwood Gilbert)]

This patch was originally assigned to :bgirard for review.  He suggested that :bas might be a good reviewer.  I'd be glad to chat if you need some background on these changes or please let me know if someone else would be better for this review.

Comment 5

[Bas Schouten (:bas.schouten)]

Comment on attachment 8767754 [details]
Bug 1284324 - Implement Canvas Layer mirrors

https://reviewboard.mozilla.org/r/62162/#review59716

This feels a little hacky to me but I don't see any issues with it, and I don't see an obvious way to make it better.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4733f9ab04e
Implement Canvas Layer mirrors r=bas

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d4733f9ab04e