Closed Bug 1284387 Opened 8 years ago Closed 8 years ago

Video controls aren't removed when tab closed

Categories

(Firefox for Android Graveyard :: Audio/Video, defect, P1)

Product:
Firefox for Android Graveyard
Component:
Audio/Video
Platform:
All
Android
Type:
defect

Tracking

(firefox47 unaffected, firefox48 unaffected, firefox49 affected, firefox50 verified)

Status:
RESOLVED FIXED
Milestone:
Firefox 50
Tracking Flags:
Tracking Status
firefox47 --- unaffected
firefox48 --- unaffected
firefox49 --- affected
firefox50 --- verified

People

(Reporter: ajones, Assigned: sebastian)

References

Details

Attachments

(1 file)

Bug 1284387 - Remove audio control notification after playing tab has been closed.
58 bytes, text/x-review-board-request
ahunt
: review+
Details 
Steps to reproduce:

* Run Firefox for Android
* Create a new tab
* Navigate to YouTube
* Play a video
* Pull down from the top of the screen - observe the pause/resume control
* Close tab

Expected results:

Pause/resume control disappears

Actual results:

Pause/resume control still shows but doesn't do anything.
Hi, Anthony,
I can't reproduce this issue in my fennec (changeset:303345).
What is the version you use for testing?
Thanks!
Flags: needinfo?(ajones)
Seems to work now so I guess it has already been fixed.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(ajones)
Resolution: --- → WORKSFORME
Can reproduce this issue now.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
The correct reproduce steps is like following.

STR
1. using Fennec to play any video
2. pause video from the control interface
3. close the playing tab

Expected.
4. the control interface should disappear

Actual.
4. the control interface still exists
[Problem]
The problem is that the control interface doesn't be informed about the video was gone.

[Why this happens]
Gecko uses the "audio-playback" event to communicate with the control interface and we have already abandoned audio focus and dispatch the "audio-playback" (inactive) after step2.

Therefore, we wouldn't "audio-playback" (inactive) again in step3, so the control interface still exists.
Priority: -- → P1
Assignee: alwu → s.kaspari
Status: REOPENED → ASSIGNED
status-firefox47: --- → unaffected
status-firefox48: --- → unaffected
status-firefox49: --- → affected
status-firefox50: --- → affected
OS: Unspecified → Android
Hardware: Unspecified → All
Attachment #8773273 - Flags: review?(ahunt) → review+
Comment on attachment 8773273 [details]
Bug 1284387 - Remove audio control notification after playing tab has been closed.

https://reviewboard.mozilla.org/r/66024/#review63430
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a735cdff3c90
Remove audio control notification after playing tab has been closed. r=ahunt
https://hg.mozilla.org/mozilla-central/rev/a735cdff3c90
Status: ASSIGNED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Video controls disappear after closing tab, so:
Verified as fixed using:
Device: One A2001 (Android 5.1.1)
Build: Firefox for Android 50.0a1 (2016-07-28)
status-firefox50: fixed → verified
I'm changing the status to verified fixed considering that the bug is verified.
Status: RESOLVED → VERIFIED
I'm changing this back to resolved fixed, I changed it by mistake.
Status: VERIFIED → RESOLVED
Closed: 8 years ago → 8 years ago
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: