1284396 - Animation uses timeline as its parent object but that object may change

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P2)

Description

[Brian Birtles (:birtles, Feb 26~ parental leave)]

As described in [1], GetParentObject() should return the same object every time. As of bug 1096776, however, Animation::GetParentObject() may no longer do that.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#Adding_WebIDL_bindings_to_a_class

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Mantaroh, do you mind taking this?

Comment 2

[Mantaroh Yoshinaga[:mantaroh]]

(In reply to Brian Birtles (:birtles) from comment #1)
> Mantaroh, do you mind taking this?
Of course!

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

I think that we need to return a single object like other animation's interfaces(e.g. AnimationEffectReadOnly/AnimationTimeline).
Animation class specified nsIGlobalObject as parent constructor's parameter. So we can return nsIGlobalObject using GetOwnerGlobal().

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6adee81cd7c97994544d5381c3534f7cfdf71ba9

Comment 4

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Bug 1284396 - Change GetParentObject return value.

Review commit: https://reviewboard.mozilla.org/r/62586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62586/

Comment 5

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8768277 [details]
Bug 1284396 - Change GetParentObject return value.

https://reviewboard.mozilla.org/r/62586/#review59308

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f56bc4cd6df
Change GetParentObject return value. r=birtles

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/5f56bc4cd6df