Closed
Bug 1284396
Opened 8 years ago
Closed 8 years ago
Animation uses timeline as its parent object but that object may change
Categories
(Core :: DOM: Animation, defect, P2)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: birtles, Assigned: mantaroh)
References
Details
Attachments
(1 file)
As described in [1], GetParentObject() should return the same object every time. As of bug 1096776, however, Animation::GetParentObject() may no longer do that. [1] https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#Adding_WebIDL_bindings_to_a_class
Assignee | ||
Comment 2•8 years ago
|
||
(In reply to Brian Birtles (:birtles) from comment #1) > Mantaroh, do you mind taking this? Of course!
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
Flags: needinfo?(mantaroh)
Assignee | ||
Comment 3•8 years ago
|
||
I think that we need to return a single object like other animation's interfaces(e.g. AnimationEffectReadOnly/AnimationTimeline). Animation class specified nsIGlobalObject as parent constructor's parameter. So we can return nsIGlobalObject using GetOwnerGlobal(). https://treeherder.mozilla.org/#/jobs?repo=try&revision=6adee81cd7c97994544d5381c3534f7cfdf71ba9
Reporter | ||
Updated•8 years ago
|
Priority: -- → P2
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/62586/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/62586/
Attachment #8768277 -
Flags: review?(bbirtles)
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8768277 [details] Bug 1284396 - Change GetParentObject return value. https://reviewboard.mozilla.org/r/62586/#review59308
Attachment #8768277 -
Flags: review?(bbirtles) → review+
Pushed by mantaroh@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5f56bc4cd6df Change GetParentObject return value. r=birtles
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5f56bc4cd6df
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•