Closed
Bug 1284403
Opened 8 years ago
Closed 8 years ago
[Browser] There's no any error message when sync/sign-in under offline
Categories
(Firefox OS Graveyard :: Gaia::TV::Browser, defect)
Tracking
(blocking-b2g:2.6+)
RESOLVED
FIXED
| blocking-b2g | 2.6+ |
People
(Reporter: mlien, Assigned: danhuang)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
From today's discussion, we may need to handle sync/sign-in under offline
|
||
Comment 1•8 years ago
|
||
Hi Dan,
Please help this issue. Thanks
Assignee: nobody → dhuang
blocking-b2g: 2.6? → 2.6+
Flags: needinfo?(dhuang)
|
||
Comment 3•8 years ago
|
||
|
Assignee | |
Comment 4•8 years ago
|
||
Comment on attachment 8768347 [details] [review]
[gaia] danhuang1202:v2.6_1284403 > mozilla-b2g:v2.6
Please help review. This patch show error message dialog when clicking the setting/sign-in button under offline. Thanks.
Attachment #8768347 -
Flags: review?(selee)
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8768347 [details] [review]
[gaia] danhuang1202:v2.6_1284403 > mozilla-b2g:v2.6
Thanks for the patch! r+
Attachment #8768347 -
Flags: review?(selee) → review+
|
|
Assignee | |
Comment 6•8 years ago
|
||
Comment on attachment 8768347 [details] [review]
[gaia] danhuang1202:v2.6_1284403 > mozilla-b2g:v2.6
Please help review again. I add two follow up commits[1][2] for update the test case. Thanks.
[1] https://github.com/mozilla-b2g/gaia/pull/34406/commits/1ac9c5f726361ea6465c3a56c0f0c9a825694b85
[2] https://github.com/mozilla-b2g/gaia/pull/34406/commits/75b7e22d2a04ba9d10284031f4d46a834e532b56
Attachment #8768347 -
Flags: review+ → review?(selee)
|
|
||
Comment 7•8 years ago
|
||
Comment on attachment 8768347 [details] [review]
[gaia] danhuang1202:v2.6_1284403 > mozilla-b2g:v2.6
There are two nits at github. Please squash all commits into one. Thank you!
Attachment #8768347 -
Flags: review?(selee) → review+
|
|
Assignee | |
Comment 8•8 years ago
|
||
Thanks for the review.
Merge in v2.6: https://github.com/mozilla-b2g/gaia/commit/6c8d51ad70dbe6ba6b81c63a6d653e5af6093f59
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•