1284417 - [Remote Control] Touch pad doesn't work while showing browser FTE page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Mike Lien[:mlien]]

[Testing Steps]
0. Fennec and TV connect to the same domain
1. Paired fennec and TV
2. Use remote control's touch pad to close browser FTE page

[Expected result]
Be able to click "Skip" or "Sign in" button to next step

[Actual result]
Touch pad doesn't work

[Build Info]
Environment: 2.6 Nexus Player
gaia:
https://github.com/mozilla-b2g/gaia/commit/efa9514dbd028bbd243246cb94e354d78ccff04b
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/a06eefe6445d36934d77accd442ee4ffa14ef19d

Fennec add-on:
https://github.com/ChunMinChang/fennec-fxos-tv/commit/6af33d674a25e92c1fa205ba64a61178de6b26dc

Comment 1

[Josh Cheng [:josh]]

Hi ChunMin, Eric
Could you check this issue?

Comment 2

[C.M.Chang[:chunmin]]

The virtual mouse(touch pad) can work to click browser buttons(home, zoom-in, ...), so I think it's gaia's bug. After tracing code in Gaia, I found the FTE page only listen 'keyup' event to handle of button press[0]. Simply add a handling in 'click' case can work for our expectation. I'll add a patch soon.

[0] https://github.com/mozilla-b2g/gaia/blob/26fb1315c57b029eb66cc1421d5df7bbd0d9acb3/shared/js/smart-screen/f_t_e_wizard.js#L205

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] ChunMinChang:bug1284417 > mozilla-b2g:v2.6

Comment 4

[C.M.Chang[:chunmin]]

Comment on attachment 8767908 [details] [review]
[gaia] ChunMinChang:bug1284417 > mozilla-b2g:v2.6

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Hi Rex,
I was wondering if you could help us to fix this issue since I am not familiar with Gaia stuff.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8767908 [details] [review]
[gaia] ChunMinChang:bug1284417 > mozilla-b2g:v2.6

Looks ok to me but I think it'd be better with a little bit change to reduce repeated code. See my Github comment.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

But it's up to you to consider my suggestion. If you need help on merging code just ask me. Thanks!

Comment 7

[C.M.Chang[:chunmin]]

Comment on attachment 8767908 [details] [review]
[gaia] ChunMinChang:bug1284417 > mozilla-b2g:v2.6

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 8

[Josh Cheng [:josh]]

Comment on attachment 8767908 [details] [review]
[gaia] ChunMinChang:bug1284417 > mozilla-b2g:v2.6

Approve for TV 2.6

Comment 9

[C.M.Chang[:chunmin]]

Please help to merge to Gaia 2.6. Thx!

Comment 10

[Fischer [:Fischer]]

Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/ace1cb9e420c432ade14f0829d33ca72c73ecc6c