1284445 - BBC fails to detect Flash Player only with Nightly (50)

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

BBC's movie news pages fail to detect Flash Player. Therefore, they say "You need to install Flash Player to play this content".

For example:
http://www.bbc.com/news/technology-36704371
http://www.bbc.com/japanese/features-and-analysis-36710962?ocid=bbc-japan-twitterjapan

I cannot reproduce it on Aurora nor Release. So, this is Nightly specific issue. Something around plugin API from JS is changed?

This is reproducible with Windows x86 and x64 builds. I don't know about Mac.

Comment 1

[Masatoshi Kimura [:emk]]

Regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d700dc054751&tochange=bcf4ff0c3eef

Pretty sure this bug 1186948 regressed this.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Thank you.

Comment 3

[Masatoshi Kimura [:emk]]

Fixed range for completeness: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6f68b8ca1b9922bf42c9e2de257ff2b5bfbad1dc&tochange=22c4e1bae9775e8765d1180ff4795b3a61b0f699

Comment 4

[Benjamin Smedberg]

Did the plugin infobar show up informing you that the site tried to use Flash? What you have described is the expected behavior so far, as long as the infobar shows up and you have the option to enable Flash.

But this was also backed out this morning for an unrelated regression.

Comment 5

[Masatoshi Kimura [:emk]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> Did the plugin infobar show up informing you that the site tried to use
> Flash?

No. Otherwise I would not have counted this as a regression.

> What you have described is the expected behavior so far, as long as
> the infobar shows up and you have the option to enable Flash.

"(Click|Tap) here to activate plugin" message or any other means (including but not limited to the infobar) to enable Flash.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> Did the plugin infobar show up informing you that the site tried to use
> Flash? What you have described is the expected behavior so far, as long as
> the infobar shows up and you have the option to enable Flash.

No, the infobar didn't appear. But it's possible to allow to run Flash Player from the locationbar. Then, reloaded page will detect Flash Player correctly.

Comment 7

[Benjamin Smedberg]

The original bug got backed out again. But Brad can you make sure this is fixed before you land again (or if you need assistance finishing up bug 1186948, talk to Felipe because that team is working on the plugin test pilot support code for FF50).

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #6)
> (In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> > Did the plugin infobar show up informing you that the site tried to use
> > Flash? What you have described is the expected behavior so far, as long as
> > the infobar shows up and you have the option to enable Flash.
> 
> No, the infobar didn't appear. But it's possible to allow to run Flash
> Player from the locationbar. Then, reloaded page will detect Flash Player
> correctly.

This is the expected behavior, no?

Comment 9

[Masatoshi Kimura [:emk]]

I didn't notice I could run Flash from the location bar because there is no notification at all. Is it also expected? There should be an infobar per comment #4.

Comment 10

[Masatoshi Kimura [:emk]]

See comment #9.

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

My intention was to show the plugin icon in the location bar when navigator.plugins is queried for flash, but not to show the notification bar unless a plugin element is created. Perhaps its better to err on over-prompting to start though, I can flip that in my updated patch.

Comment 12

[Benjamin Smedberg]

Yeah, I think we should err on over-prompting. By design, the click-to-activate UI always expects something to be visible on the page for clicking. The user research showed that the icon by itself was not enough, even for advanced users who knew what was going on.