Closed
Bug 1284597
Opened 8 years ago
Closed 8 years ago
Control validation does not support multiline JEXL expressions or custom filters
Categories
(Firefox :: Normandy Server, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: osmose, Assigned: mythmon)
References
Details
The JEXL validation in the control interface does not currently support multiline JEXL expressions nor does it support the custom filters we use in the self-repair runtime. They should both be using the same code.
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → mkelly
Reporter | ||
Comment 1•8 years ago
|
||
Unassigning this in case someone else wants to take it. I have an in-progress commit at https://github.com/Osmose/normandy/commit/6c7d1dee43bc6d343e3e839e1426c97714f69633 that was aimed at seeing if we could use CodeMirror for editing JEXL, but it also includes some work for making self-repair and the validation use the same JEXL instance that may be useful to someone else taking on this bug.
Assignee: mkelly → nobody
Assignee | ||
Comment 2•8 years ago
|
||
Grabbing this to work on along with bug 1280196. I'll likely fix them together.
Assignee: nobody → mcooper
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•8 years ago
|
||
Robot can't handle two bug closures, I guess. This was fixed in https://github.com/mozilla/normandy/pull/195.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Shield → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•