Closed
Bug 1284713
Opened 9 years ago
Closed 9 years ago
UI doesn't escape bold ansi escape sequences in logs
Categories
(Taskcluster :: UI, defect)
Taskcluster
UI
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: banderson, Unassigned)
Details
Rust tools output bold colors on the terminal with ansi escape sequences. TC is not interpreting them in its HTML UI and instead displays `(B`.
Example: https://tools.taskcluster.net/task-inspector/#muIC2DJeSbqRXfP2z8b8tg/0
Comment 1•9 years ago
|
||
Eli - is this hard to fix?
Component: General → Tools
Flags: needinfo?(eperelman)
Comment 2•9 years ago
|
||
I believe this is caused by https://github.com/drudru/ansi_up/issues/29
Comment 3•9 years ago
|
||
Brian is correct, and looking through the library code, anything with bold escapes aren't given special styling. Also from the README of ansi_up:
> This function only interprets ANSI SGR (Select Graphic Rendition) codes that can be represented in HTML. > For example, cursor movement codes are ignored and hidden from output.
My guess is the regex they are using doesn't include the escape sequences being rendered from the Rust log. Does the Rust log contain characters that are incompatible with ansi_up codes?
https://public-artifacts.taskcluster.net/muIC2DJeSbqRXfP2z8b8tg/0/public/logs/live_backing.log
Regardless, we probably should see if there is a more robust ANSI-to-markup solution out there.
Flags: needinfo?(eperelman)
Comment 4•9 years ago
|
||
We have since implemented a new log viewer which address many display problems, and should address this one as well.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
| Assignee | ||
Updated•7 years ago
|
Component: Tools → UI and Tools
You need to log in
before you can comment on or make changes to this bug.
Description
•