1284851 - Unable to scroll if the focus from the filename is lost while the tooltip is visible

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Ada [:adalucinet]]

Attachment: Screen recording

[Affected versions]:
- latest Nightly 50.0a1

[Affected platforms]:
- Windows 10 64-bit
- Mac OS X 10.11.1
- Ubuntu 16.04 64-bit

[Steps to reproduce]:
1. Launch Firefox
2. Open Network Monitor.
3. Navigate to any page (E.g.: http://imgur.com/)
4. In the Network request list, hover over a thumbnail of any image.
5. Move mouse cursor at the bottom of the thumbnail (so that the focus from the filename is lost, but the tooltip is still displayed)
6. Scroll up/down.

[Expected result]: Scrolling up/down is working accordingly.

[Actual result]: Unable to scroll.

[Regression range]:
- Last good revision: ddb6b30149221f00eb5dd180530e9033093d4c2b
- First bad revision: 53f5b5c289fba6ad82c675578cf1c548ae37f0c1
- Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ddb6b30149221f00eb5dd180530e9033093d4c2b&tochange=53f5b5c289fba6ad82c675578cf1c548ae37f0c1 
- I guess this was regressed by bug 1277264

[Additional notes]:
- Screen recording attached.

Comment 1

[Marco Mucci [:MarcoM]]

Needs to block the Track #1 Meta for tracking team work.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1284851 - fix HTMLTooltip capturing events on invisible arrow container;

Review commit: https://reviewboard.mozilla.org/r/62722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62722/

Comment 3

[Julian Descottes [:jdescottes]]

Took me a while to understand what the actual regression was about, so I'll add some details here in case it helps the review.

The tooltip arrow is a ::before element wrapped in a container. Pointer events used to be enabled on the whole container, which means that the mouse pointer could be visually outside of the arrow while still being on the arrow container (as we can see in the screen recording).

This patch simply moves the "pointer-events: all" rule to the ::before element (the actual arrow) instead of the arrow container. This restores the same behavior as before the HTMLTooltip migration. Of course if the pointer is really on the arrow or on the tooltip, the scroll will not occur, but that's the expected behavior.

Comment 4

[Julian Descottes [:jdescottes]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=21d2203f24a6

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8768528 [details]
Bug 1284851 - fix HTMLTooltip capturing events on invisible arrow container;

Just tested using the XUL panel wrapper and it looks like scroll events are swallowed much more often now. Will take a look before submitting for review.

Comment 6

[Julian Descottes [:jdescottes]]

I have decided to propose to switch the xulWrapper off by default (Bug 1285189). I will open dedicated Bugs to resolve the scroll issue linked to the XUL wrapper.

This way we can move forward and discuss the fix for the initial issue here.

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8768528 [details]
Bug 1284851 - fix HTMLTooltip capturing events on invisible arrow container;

https://reviewboard.mozilla.org/r/62722/#review59750

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/8be08b36d5d8
fix HTMLTooltip capturing events on invisible arrow container;r=bgrins

Comment 9

[Gregory Szorc [:gps]]

Out of curiosity, why wasn't this autolanded using MozReview?

Comment 10

[Brian Grinstead [:bgrins]]

(In reply to Gregory Szorc [:gps] from comment #9)
> Out of curiosity, why wasn't this autolanded using MozReview?

Mostly because I'm used to letting the patch author decide when to push / mark for checkin.  Also didn't see the button in the UI, although now I do.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8be08b36d5d8

Comment 12

[Ada [:adalucinet]]

Verified fixed using latest Nightly 50.0a1, under Windows 10 64-bit, Ubuntu 16.04 64-bit and Mac OS X 10.11.1.