1284895 - releasetasks should retry network request

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

We have some API calls (hgweb for example), that we may want to retry in case there is some network blip or something.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: Retry get_json_rev using redo module

Decorated the call with the retriable decorator. Does this accomplish what you describe? Couldn't find any other network requests to take care of.

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8772144 [details] [diff] [review]
Retry get_json_rev using redo module

It should just work!

Also, to make it work in production, we'd need to add redo to the list of releaserunner's deps (which uses releasetasks) in http://hg.mozilla.org/build/puppet/file/tip/modules/releaserunner/manifests/init.pp#l50

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: Add redo to releaserunner puppet deps

Added the dependency, have never used puppet so I just followed the pattern. If this is correct I will make a releasetasks PR.

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8772162 [details] [diff] [review]
Add redo to releaserunner puppet deps

I downloaded 1.5 to http://puppetagain.pub.build.mozilla.org/data/python/packages/ to make it available for puppet.

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8772162 [details] [diff] [review]
Add redo to releaserunner puppet deps

remote:   https://hg.mozilla.org/build/puppet/rev/9fc8fedfab6b
remote:   https://hg.mozilla.org/build/puppet/rev/a78c5aaf3a26