releasetasks should retry network request

RESOLVED FIXED

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rail, Assigned: csheehan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

We have some API calls (hgweb for example), that we may want to retry in case there is some network blip or something.
Decorated the call with the retriable decorator. Does this accomplish what you describe? Couldn't find any other network requests to take care of.
Attachment #8772144 - Flags: feedback?(rail)
Comment on attachment 8772144 [details] [diff] [review]
Retry get_json_rev using redo module

It should just work!

Also, to make it work in production, we'd need to add redo to the list of releaserunner's deps (which uses releasetasks) in http://hg.mozilla.org/build/puppet/file/tip/modules/releaserunner/manifests/init.pp#l50
Attachment #8772144 - Flags: feedback?(rail) → feedback+
Added the dependency, have never used puppet so I just followed the pattern. If this is correct I will make a releasetasks PR.
Attachment #8772162 - Flags: review?(rail)
Comment on attachment 8772162 [details] [diff] [review]
Add redo to releaserunner puppet deps

I downloaded 1.5 to http://puppetagain.pub.build.mozilla.org/data/python/packages/ to make it available for puppet.
Attachment #8772162 - Flags: review?(rail) → review+
Assignee: nobody → csheehan
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.