1284909 - Need to write code for observing deviceId constraints for screensharing

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Florian Quèze [:florian]]

While discussing over IRC how to get previews for screensharing (bug 1284877), jib said that we have deviceIds for screensharing "devices", but no code for observing the deviceId constraint for screensharing.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1284909 - Allow raw deviceId constraints in gUM when caller is chrome.

Review commit: https://reviewboard.mozilla.org/r/73036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73036/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8783071 [details]
Bug 1284909 - Allow raw deviceId constraints in gUM when caller is chrome.

https://reviewboard.mozilla.org/r/73036/#review71386

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8783071 [details]
Bug 1284909 - Allow raw deviceId constraints in gUM when caller is chrome.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73036/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f43357fe5b4
Allow raw deviceId constraints in gUM when caller is chrome. r=jesup

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d93123e16c0
Backed out changeset 5f43357fe5b4 for bustage on a CLOSED TREE.

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8783071 [details]
Bug 1284909 - Allow raw deviceId constraints in gUM when caller is chrome.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73036/diff/2-3/

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8783071 [details]
Bug 1284909 - Allow raw deviceId constraints in gUM when caller is chrome.

Had to move some refactoring from bug 1284680 to here to avoid bouncing. jesup if you could take another look that'd be great (diff 3) (diff 2 is a rebase).

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8783071 [details]
Bug 1284909 - Allow raw deviceId constraints in gUM when caller is chrome.

https://reviewboard.mozilla.org/r/73036/#review73582

Comment 9

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8783071 [details]
Bug 1284909 - Allow raw deviceId constraints in gUM when caller is chrome.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73036/diff/3-4/

Comment 10

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Rebased.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ee60e05ce18
Allow raw deviceId constraints in gUM when caller is chrome. r=jesup

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ee60e05ce18