Extend KEYGEN_GENERATED_KEY_TYPE until Firefox 55

RESOLVED FIXED in Firefox 50

Status

()

Core
Security: PSM
P1
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: kmckinley, Assigned: kmckinley)

Tracking

unspecified
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

2 years ago
We need continue to collect data to determine whether we should remove keygen, keep as-is, or update it in some way.
(Assignee)

Comment 1

2 years ago
Created attachment 8768474 [details] [diff] [review]
Bump the version number

Allison, do we need a privacy review if all we are doing is bumping the version number?
Attachment #8768474 - Flags: review?(dkeeler)
Attachment #8768474 - Flags: feedback?(a.m.naaktgeboren)
Comment on attachment 8768474 [details] [diff] [review]
Bump the version number

Review of attachment 8768474 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, r=me. Not sure if a telemetry peer needs to sign off on this. I assume Ally will tell us.
Attachment #8768474 - Flags: review?(dkeeler) → review+
(Assignee)

Comment 3

2 years ago
Created attachment 8768534 [details] [diff] [review]
Bump the version number
Attachment #8768474 - Attachment is obsolete: true
Attachment #8768474 - Flags: feedback?(a.m.naaktgeboren)
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Attachment #8768534 - Flags: review+
Attachment #8768534 - Flags: feedback?(a.m.naaktgeboren)
Priority: -- → P1
Whiteboard: [psm-assigned]
(Assignee)

Updated

2 years ago
Flags: needinfo?(a.m.naaktgeboren)
Attachment #8768534 - Flags: feedback?(a.m.naaktgeboren)
Comment on attachment 8768534 [details] [diff] [review]
Bump the version number

Review of attachment 8768534 [details] [diff] [review]:
-----------------------------------------------------------------

Apologies for the delay, I have been sick.

Yes, you do need a review from data collection to extend collection, especially release collection ones.

From a technical perspective, please add the bug number field to the probe since you are updating it. Bonus points if you also add Bug 1191414, to that list, as that's the original bug for this probe as far as I can tell.

Release collection probes have a higher bar of justification. Please explain why the previous data collection for from the last 10 months or so hasn't been sufficient and why 10 more versions will. 

I'm not adverse to allowing a bump, but it needs to be justified. I promise I'm not trying to make your lives any more difficult than need be.
Attachment #8768534 - Flags: feedback+
See review comment above.
Flags: needinfo?(a.m.naaktgeboren)
One of the concerns we've had around removing keygen is that usage might not be uniformly distributed in time. That is, there might be parts of the year that have a huge spike in usage (e.g. for voting or submitting taxes). Having at least full year's worth of data will go a long way towards either confirming or disproving this theory, and in any case it will give us a better idea of whether or not we can remove keygen without negatively impacting too many users.
(In reply to David Keeler [:keeler] (use needinfo?) from comment #6)
> One of the concerns we've had around removing keygen is that usage might not
> be uniformly distributed in time. That is, there might be parts of the year
> that have a huge spike in usage (e.g. for voting or submitting taxes).
> Having at least full year's worth of data will go a long way towards either
> confirming or disproving this theory, and in any case it will give us a
> better idea of whether or not we can remove keygen without negatively
> impacting too many users.

Then let us say Firefox 55 as the expiration? That in addition to the data already collected, should give you a full year and then some. 

It also may be in your best interest to ping whoever is in charge of telemetry servers to verify that the data from this probe will be kept for a full year.  

Using expiration 55 + changes in comment 4 p=ally.
Flags: needinfo?(dkeeler)
(Assignee)

Comment 8

2 years ago
Created attachment 8773057 [details] [diff] [review]
Bump the version number to FF55 to give a year of data

Updated expiration to version 55 and added the bug numbers.
Attachment #8768534 - Attachment is obsolete: true
Flags: needinfo?(dkeeler)
Attachment #8773057 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 9

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e543221ad4ee
update KEYGEN_GENERATED_KEY_TYPE to collect until Firefox 60. r=keeler,p=ally
Keywords: checkin-needed

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e543221ad4ee
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50

Comment 11

a year ago
(Updating summary to reflect that the extension ended up being up to 55 instead of 60.)
Summary: Extend KEYGEN_GENERATED_KEY_TYPE until Firefox 60 → Extend KEYGEN_GENERATED_KEY_TYPE until Firefox 55

Updated

a year ago
See Also: → bug 1346299
You need to log in before you can comment on or make changes to this bug.