1284986 - JavaScript error: chrome://browser/content/pageinfo/permissions.js, line 224: Error: Callback received for bad URI: [xpconnect wrapped nsIURI @ 0x12cf99d40 (native @ 0x1356f7b08)]

Status: NEW

(Firefox :: Page Info Window, defect, P5)

Description

[Kamil Jozwiak [:kjozwiak]]

When clicking on "More Information" under the control centre, you'll receive the following error under the browser console:

JavaScript error: chrome://browser/content/pageinfo/permissions.js, line 224: Error: Callback received for bad URI: [xpconnect wrapped nsIURI @ 0x1217ba2e0 (native @ 0x135ca8e08)]

STR:

* launch the latest version of m-c
* load https://bitcoin.org/bitcoin.pdf in a new tab and open the browser console
* select "More Information" under the control centre

Comment 1

[magicp]

I can reproduce this bug on Windows, OSX and Linux with the following steps

1. Start Firefox 49b or later version
2. Go to "https://www.mozilla.org/en-US/firefox/tracking-protection/start/"
3. Open Browser Console (Ctrl+Shift+J)
4. Select "View Page Info" in context menu
5. Check error in Browser Console

Error: Callback received for bad URI: [xpconnect wrapped nsIURI]	permissions.js:224:11
  onIndexedDBUsageCallback	chrome://browser/content/pageinfo/permissions.js:224:11

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ac7cdaeb19675e6897e31531868b19f128950a65&tochange=6cd8c193328d7cdae0686d7e5783351a09c773e6

Bug 1233885 - fix up docInfo and permission manager to use default user context

Comment 2

[Kamil Jozwiak [:kjozwiak]]

Dave, mind taking a quick look? The regression range in comment#1 points to work that was done in bug#1233885.

Comment 3

[Dave Huseby [:huseby]]

I'll take a look at this.

Comment 4

[Tanvi Vyas[:tanvi]]

Flagging fxprivacy triage just so that the team sees it.

From what I can tell, the Page Info section still works, right Kamil?

I'm not sure if this is an OA bug, but tagging it anyway for now.

Comment 5

[Erin Lancaster [:elan]]

P5 for now unless we discover it this is breaking something.

Comment 6

[Florian Quèze [:florian]]

The error is at:
http://searchfox.org/mozilla-central/rev/c1e745733c84630821ef53754b627f2c0b0b5202/browser/base/content/pageinfo/permissions.js#224

uri = resource://pdf.js/web/viewer.html
gPermURI = https://bitcoin.org/bitcoin.pdf

So the problem is at http://searchfox.org/mozilla-central/rev/c1e745733c84630821ef53754b627f2c0b0b5202/browser/base/content/content.js#1054 where we get a principal for the PDF.js viewer rather than for the actual document.

Comment 7

[Kamil Jozwiak [:kjozwiak]]

(In reply to Tanvi Vyas [:tanvi] from comment #4)
> From what I can tell, the Page Info section still works, right Kamil?

Yup, that's correct. The Page Info still works even though the browser console is displaying the error. I checked both cases. Viewed the Page Info section using the following access methods:

* control centre -> more information (case from comment #0)
* right click context menu -> view page info (case from comment#1)

Comment 8

[Tanvi Vyas[:tanvi]]

(In reply to Florian Quèze [:florian] [:flo] from comment #6)
> The error is at:
> http://searchfox.org/mozilla-central/rev/
> c1e745733c84630821ef53754b627f2c0b0b5202/browser/base/content/pageinfo/
> permissions.js#224
> 
> uri = resource://pdf.js/web/viewer.html
> gPermURI = https://bitcoin.org/bitcoin.pdf
> 
> So the problem is at
> http://searchfox.org/mozilla-central/rev/
> c1e745733c84630821ef53754b627f2c0b0b5202/browser/base/content/content.
> js#1054 where we get a principal for the PDF.js viewer rather than for the
> actual document.

Florian, do you know if the uri mismatch is because of the origin suffix with the OriginAttributes, or the scheme/host/port themselves are mismatched?

Comment 9

[Florian Quèze [:florian]]

(In reply to Tanvi Vyas [:tanvi] from comment #8)

> Florian, do you know if the uri mismatch is because of the origin suffix
> with the OriginAttributes, or the scheme/host/port themselves are mismatched?

Between resource://pdf.js/web/viewer.html and https://bitcoin.org/bitcoin.pdf the whole URL is different.

Comment 10

[Tanvi Vyas[:tanvi]]

(In reply to Florian Quèze [:florian] [:flo] from comment #9)
> (In reply to Tanvi Vyas [:tanvi] from comment #8)
> 
> > Florian, do you know if the uri mismatch is because of the origin suffix
> > with the OriginAttributes, or the scheme/host/port themselves are mismatched?
> 
> Between resource://pdf.js/web/viewer.html and
> https://bitcoin.org/bitcoin.pdf the whole URL is different.

Okay, then removing the Origin Attribute white board flags.  If this does end up being an Origin Attributes bug, please let us know.  Thanks!

Comment 11

[Florian Quèze [:florian]]

(In reply to Tanvi Vyas [:tanvi] from comment #10)
> (In reply to Florian Quèze [:florian] [:flo] from comment #9)
> > (In reply to Tanvi Vyas [:tanvi] from comment #8)
> > 
> > > Florian, do you know if the uri mismatch is because of the origin suffix
> > > with the OriginAttributes, or the scheme/host/port themselves are mismatched?
> > 
> > Between resource://pdf.js/web/viewer.html and
> > https://bitcoin.org/bitcoin.pdf the whole URL is different.
> 
> Okay, then removing the Origin Attribute white board flags.  If this does
> end up being an Origin Attributes bug, please let us know.  Thanks!

Well, it's still a regression caused by bug 1233885, as before that patch the permissions tab of the Page Info window didn't look at the principal's URI.

Comment 12

[Tanvi Vyas[:tanvi]]

Do you think we should use docInfo.principal = document.nodePrincipal to get the OriginAttributes.  And then create a codebase principal from URI with the originAttributes from document.nodePrincipal?