Closed Bug 1285086 Opened 4 years ago Closed 4 years ago

Turn on WebGLSampler

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: ethlin, Assigned: ethlin)

References

Details

Attachments

(2 files, 1 obsolete file)

We should turn on WebGLSampler to pass the conformance test "conformance2/samplers/samplers.html" and "conformance2/samplers/sampler-drawing-test.html". I tried to turn on it and the tests passed.
Attached patch turn on websampler (obsolete) — Splinter Review
Is there anything else we need to do before turing the WebSampler on?
Flags: needinfo?(jgilbert)
Attachment #8768624 - Flags: review+
I don't think so.
Flags: needinfo?(jgilbert)
Fix warning.
Attachment #8768624 - Attachment is obsolete: true
Attached patch Enable tests.Splinter Review
Enable tests.
Attachment #8773299 - Flags: review?(jgilbert)
Attachment #8773299 - Flags: review?(jgilbert) → review?(mtseng)
Comment on attachment 8773299 [details] [diff] [review]
Enable tests.

Good!
Attachment #8773299 - Flags: review?(mtseng) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75c5c25b63f3
Turn on WebGLSampler. r=jgilbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca576dc267ed
Enable related webgl conformance test. r=jgilbert
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/75c5c25b63f3
https://hg.mozilla.org/mozilla-central/rev/ca576dc267ed
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.