1285087 - Hide browser app from Apps Deck

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Mike Lien[:mlien]]

[Testing Steps]
1. Home -> Navigate to Browser
2. Press option key

[Expected result]
Can be rename/unpin from home

[Actual result]
1. Only support move
2. Default home contains: TV, Apps, Devices, Browser but the add folder icon is disappear

[Build Info]
Environment: 2.6 Nexus Player
gaia:
https://github.com/mozilla-b2g/gaia/commit/ace1cb9e420c432ade14f0829d33ca72c73ecc6c
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/b7f962788a7fa3fc8e49a33a4b4e7799730a3937

Comment 1

[Luke Chang [:lchang] (inactive)]

Hi Jack,

We need you to define whether Browser is Deck or not. Thanks.

Comment 2

[Jack Lin[:jacklin]]

Hi Luke,

I suggest that Browser is not Deck. 

I am wondering if we define Browser is Deck, how the user distinguishs "Browser pinned from Apps" and "Browser already on Home screen"? The option menu would be different and UX would be inconsistent.

Thank you very much
Jack

Comment 3

[Luke Chang [:lchang] (inactive)]

To change the browser app's type will lead to risks and more UX problems. For instance, apps pinned to home from Apps Deck will be treated as "Application" group, so the pinned Browser app will appear in "Application" filter rather than "Web" filter.

To fix all of these problems is a huge work. After offline discussed with Jack, we decided to hide the Browser app from Apps Deck. It will be much easier at this moment.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1285087_tv_hide_browser_from_appdeck > mozilla-b2g:v2.6

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8769566 [details] [review]
[gaia] luke-chang:1285087_tv_hide_browser_from_appdeck > mozilla-b2g:v2.6

Rex, Another one-line patch. Thanks.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8769566 [details] [review]
[gaia] luke-chang:1285087_tv_hide_browser_from_appdeck > mozilla-b2g:v2.6

Again, I would suggest discuss this kind of huge spec change at the initial stage next time. 
Hiding the browser icon makes the original design look weird, especially for the grouping system and pinned webpages.

Comment 7

[Luke Chang [:lchang] (inactive)]

Rex, Thanks.

landed on v2.6: https://github.com/mozilla-b2g/gaia/commit/fc19eb4978bd8bee8a6a9a7f2b43876c31dc9315