Closed Bug 1285099 Opened 3 years ago Closed 3 years ago

STATE_PENDING_SVC is not defined in nsUpdateService.js

Categories

(Toolkit :: Application Update, defect)

49 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox47 --- unaffected
firefox48 --- unaffected
firefox49 - fixed
firefox-esr45 --- unaffected
b2g-v2.6 --- unaffected
thunderbird_esr45 --- unaffected
firefox50 --- fixed

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch patchSplinter Review
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #8768639 - Flags: review?(spohl.mozilla.bugs)
Attachment #8768639 - Flags: review?(spohl.mozilla.bugs) → review+
We should probably get this into 49, would you agree?
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8994cce5e6b8
STATE_PENDING_SVC is not defined in nsUpdateService.js after bug 394984 landed. r=spohl
[Tracking Requested - why for this release]: this is a regression from bug 394984 which landed for Firefox 49 and it prevents proper error handling when staging an update.
https://hg.mozilla.org/mozilla-central/rev/8994cce5e6b8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Version: unspecified → 49 Branch
Comment on attachment 8768639 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Bug 394984
[User impact if declined]: This bug prevents proper error handling when staging an update.
[Describe test coverage new/current, TreeHerder]: This has been on nightly for awhile without problems. I will try to come up with a test for this in the near future as time permits.
[Risks and why]: Minimal. This reverts the code back to the way it was previously.
[String/UUID change made/needed]: None
Attachment #8768639 - Flags: approval-mozilla-aurora?
Comment on attachment 8768639 [details] [diff] [review]
patch

Reverts this bit of update behavior to fix a regression in 49, please uplift
Attachment #8768639 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.