Closed Bug 1285099 Opened 8 years ago Closed 8 years ago

STATE_PENDING_SVC is not defined in nsUpdateService.js

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Version:
49 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox47 --- unaffected
firefox48 --- unaffected
firefox49 - fixed
firefox-esr45 --- unaffected
b2g-v2.6 --- unaffected
thunderbird_esr45 --- unaffected
firefox50 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch
1.07 KB, patch
spohl
: review+
lizzard
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED

        Attachment #8768639 -
        Flags: review?(spohl.mozilla.bugs)

        Attachment #8768639 -
        Flags: review?(spohl.mozilla.bugs) → review+

    
    

    
  
We should probably get this into 49, would you agree?

    
    

    
  
Planned on it

    
    

    
  
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8994cce5e6b8
STATE_PENDING_SVC is not defined in nsUpdateService.js after bug 394984 landed. r=spohl

    
    

    
  
[Tracking Requested - why for this release]: this is a regression from bug 394984 which landed for Firefox 49 and it prevents proper error handling when staging an update.

          tracking-firefox49:
          --- → ?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/8994cce5e6b8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox50:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Version: unspecified → 49 Branch

    
    

    
  
Comment on attachment 8768639 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Bug 394984
[User impact if declined]: This bug prevents proper error handling when staging an update.
[Describe test coverage new/current, TreeHerder]: This has been on nightly for awhile without problems. I will try to come up with a test for this in the near future as time permits.
[Risks and why]: Minimal. This reverts the code back to the way it was previously.
[String/UUID change made/needed]: None

        Attachment #8768639 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8768639 [details] [diff] [review]
patch

Reverts this bit of update behavior to fix a regression in 49, please uplift

        Attachment #8768639 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: