1285156 - Too short interval of pressing OK key down and up will cause failed to open top sites' web page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

Description

[Mike Lien[:mlien]]

[Testing Steps]
1. Launch Browser app
2. Spatial navigation to any top site item
3. Press OK key down and up within a short interval

[Expected result]
Web page can be opened

[Actual result]
Failed to open web page

[Build Info]
Environment: 2.6 Nexus Player
gaia:
https://github.com/mozilla-b2g/gaia/commit/ace1cb9e420c432ade14f0829d33ca72c73ecc6c
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/b7f962788a7fa3fc8e49a33a4b4e7799730a3937

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:v2.6_1285156 > mozilla-b2g:v2.6

Comment 2

[Dan Huang[:danhuang]]

Comment on attachment 8769576 [details] [review]
[gaia] danhuang1202:v2.6_1285156 > mozilla-b2g:v2.6

Please help review. This patch add keycode handler for displaying top-site by pressing OK button. Thanks.

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8769576 [details] [review]
[gaia] danhuang1202:v2.6_1285156 > mozilla-b2g:v2.6

The fix is a bit strange, but I'm fine with that if it works.

Comment 4

[Dan Huang[:danhuang]]

Comment on attachment 8769576 [details] [review]
[gaia] danhuang1202:v2.6_1285156 > mozilla-b2g:v2.6

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):TV 2.6
[User impact] if declined: quick click top-site wouldn't work 
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None

Comment 5

[Josh Cheng [:josh]]

Comment on attachment 8769576 [details] [review]
[gaia] danhuang1202:v2.6_1285156 > mozilla-b2g:v2.6

Approve for TV 2.6

Comment 6

[Dan Huang[:danhuang]]

Merge in v2.6: https://github.com/mozilla-b2g/gaia/commit/a2ad61ba3ba848265fc10b13416e971effe212dd