1285226 - [Linux] [Narrate] The English (en-GB) voice appears four times in the list

Status: NEW

(Toolkit :: Reader Mode, defect, P3)

Description

[Camelia Badau [:cbadau], Desktop Test Engineering]

Attachment: issue.png

[Affected versions]:
- Firefox 48.0a1 (2016-03-07)
- Firefox 48 Beta 5 (2016-06-30)
- Firefox 49.0a2 (2016-07-07)
- Firefox 50.0a1 (2016-07-06)


[Affected platforms]:
- Ubuntu 14.04 64bit
- Ubuntu 13.10 32bit

[Steps to reproduce]:
1. Launch Firefox.
2. Open a page in Reader Mode.
3. In the left toolbar, click the third icon from the top (the Narrate icon).
4. Open voice-select ("Voice") and observe the list of voices.

[Expected result]:
- Each voice appears only once in the list.

[Actual result]:
- The English (en-GB) voice appears four times in the list. Please see attached screenshot "issue.png". 

[Regression range]:
- It is not a regression, it reproduces since the feature landed in Firefox (Nightly 48.0a1: 2016-03-07).

[Additional notes]: 
- The issue is reproducible only on Ubuntu.

Comment 1

[:Gijs (he/him)]

Eitan, any idea what's up with this bug? Also, can you tweak the 'affected' flags based on where we're actually shipping this (49, I think)? Should this live in Core :: Web Speech or is the reader mode narrate code doing something stupid here?

Comment 2

[Eitan Isaacson [:eeejay]]

I suspect this is a label choice issue. eSpeak comes with a few options for languages with many variations. For example, a Welsh and Scottish voice for en-GB. To make it more user friendly we may need to have a mapping of eSpeak voices to localized names.

Keeping the ni until we resolve this..

Comment 3

[Eitan Isaacson [:eeejay]]

Here is the deal..

In Linux the default voices are all eSpeak. eSpeak historically doesn't do a good job with consistent naming and correct BCP47 language tags. It also is not actively maintained anymore, which is a separate issue.

Recently a for of eSpeak was created called espeak-ng. In February of this year they did a good job in making the voice names more consistent and properly using BCP47 in language names. Distros are probably not going to package espeak-ng in the near future.

I propose creating a mapping from the old espeak voice name/language pairs to the more correct version.

This would be a change in our Linux synth support. It will propagate to Narrate in the form of a more nuanced list of british voices:

* English (en-GB)
* English (en-GB-scotland)
* English (en-GB-x-gbclan) // Northern UK accent?
* English (en-GB-x-gbcwmd) // West midlands accent?

This is not perfect at all. But at least we won't have 4 identical labels.'

I'll open a blocker for this bug.

Comment 4

[Eitan Isaacson [:eeejay]]

Here is the espeak-ng changeset for reference:
https://github.com/espeak-ng/espeak-ng/commit/77b5f6a1c0dbe52d9aba9647489e86f6d625236e

Comment 5

[:Gijs (he/him)]

(In reply to Eitan Isaacson [:eeejay] from comment #3)
> I'll open a blocker for this bug.

Did this get opened but not marked as blocking/depending on this, or something? :-)

Comment 6

[Eitan Isaacson [:eeejay]]

Oops! I forgot. Here it is.

Comment 7

[Evan Tseng [:evanxd]]

Hi Eitan,

Looks like if Bug 1294468 is fixed then this bug could be fixed. So we can say this bug is a duplicate of Bug 1294468, right?

Comment 8

[Eitan Isaacson [:eeejay]]

I would keep it as a blocker. One issue may resolve another, but they are not duplicates.

Comment 9

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is a P1 bug without an assignee. 

P1 are bugs which are being worked on for the current release cycle/iteration/sprint. 

If the bug is not assigned by Monday, 28 August, the bug's priority will be reset to '--'.

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I tested against Firefox 99.0b7(20220322185926) and it reproduces as such:

• There are 7 English(en) options from the Voice dropdown;
• The default voice and the voice options from the dropdown menu are the same;