1285231 - Don't use Move() to empty plugins list in GMPServiceParent.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I've used Move() to move the contents of the plugins list to a local variable in GeckoMediaPluginServiceParent::UnloadPlugins(), expecting that the source list would be emptied. However misleadingly-named Move() does not guarantee that the source object will actually be emptied.
https://hg.mozilla.org/mozilla-central/annotate/09221c72fcb03a7c2b4ab27c75304eae3247e3d1/dom/media/gmp/GMPServiceParent.cpp#l722

An easy fix in this case should be to just swap the contents of the local (empty) list with the plugins list.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1285231 - Use Swap to move&empty plugins list before unloading -

Review commit: https://reviewboard.mozilla.org/r/62838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62838/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8768788 [details]
Bug 1285231 - Use Swap to move&empty plugins list before unloading -

https://reviewboard.mozilla.org/r/62838/#review59736

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you for the review, JW.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a123c6c6dbf
Use Swap to move&empty plugins list before unloading - r=jwwang

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9a123c6c6dbf