Closed Bug 1285234 Opened 9 years ago Closed 9 years ago

Intermittent test_bug659071.html | uncaught exception - TypeError: this.controlListeners is undefined at chrome://global/content/bindings/videocontrols.xml:651:30

Categories

(Toolkit :: Video/Audio Controls, defect, P5)

Product:
Toolkit
Component:
Video/Audio Controls
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jaws)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1285234 - Check for valid videoEvents and controlListeners before dereferencing them in case the videocontrols have been cleaned up already.
58 bytes, text/x-review-board-request
Gijs
: review+
Details
Likely the front-end to playback, so may need further reclassification
Component: Audio/Video → Audio/Video: Playback
Flags: needinfo?(ajones)
Flags: needinfo?(ajones)
Priority: -- → P5
Any thoughts, Jared?
Component: Audio/Video: Playback → Video/Audio Controls
Flags: needinfo?(jaws)
Product: Core → Toolkit
It's not clear to me why the controlListeners don't exist anymore or as to why this would start failing now, but it wouldn't hurt to check if they do exist before dereferencing them. There's also no change to videocontrols.xml around the same time that this bug was filed.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Comment on attachment 8772216 [details] Bug 1285234 - Check for valid videoEvents and controlListeners before dereferencing them in case the videocontrols have been cleaned up already. https://reviewboard.mozilla.org/r/65076/#review62216 rs=me with the below fixed. ::: toolkit/content/widgets/videocontrols.xml:644 (Diff revision 1) > this.log("!!! event " + aEvent.type + " not handled!"); > } > }, > > terminateEventListeners : function () { > + if (tihs.videoEvents) { Typo. :-\ ::: toolkit/content/widgets/videocontrols.xml:660 (Diff revision 1) > - element.item.removeEventListener(element.event, element.func, > + element.item.removeEventListener(element.event, element.func, > - { mozSystemGroup: true }); > + { mozSystemGroup: true }); > - } > + } > + } > > delete this.controlListeners; This should probably be in the if statement as well.
Attachment #8772216 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8772216 [details] Bug 1285234 - Check for valid videoEvents and controlListeners before dereferencing them in case the videocontrols have been cleaned up already. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/65076/diff/1-2/
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/067b8bda91ed Check for valid videoEvents and controlListeners before dereferencing them in case the videocontrols have been cleaned up already. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/067b8bda91ed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: